Made BN_ARRAY_SIZE fully configurable with defines#35
Open
krysperz2 wants to merge 1 commit intokokke:masterfrom
Open
Made BN_ARRAY_SIZE fully configurable with defines#35krysperz2 wants to merge 1 commit intokokke:masterfrom
krysperz2 wants to merge 1 commit intokokke:masterfrom
Conversation
|
@kokke Is there any reason we can't merge this patch? As I understand it, we may need to adjust the tests, but is there anything else? |
|
Comparing this to #21 I guess the reason you dont accept such changes is that this library build system (Makefile) does not support propagation of compile definition to consumers of this library, so switching library behaviour with ifdefs in header file is problematic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.