fix: io, web consistent Completer.complete #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @konsultaner, thanks for creating this package.
I noticed in
lib/src/transport/websocket/websocket_transport_io.dart,completeis used fromlib/src/transport/abstract_transport.dartcomplete(_onDisconnect, error);completeis also used inlib/src/transport/websocket/websocket_transport_web.dartto close_onConnectionLost,_onDisconnect.This PR aligns
websocket_transport_ioto usecompleteover manual completion, e.g.In the case of
_onConnectionLost!.complete()being called multiple times, this results inUnhandled Exception: Bad state: Future already completederrors as a completer should only be completed once. The existing methodcompleteexplicitly checks if the completer has already been completed before invokingcomplete.