Exec: disable term resizes on windows

SIGWINCH does not exist, it breaks the build

Author: nicoche

pkg/koyeb/instances_exec.go

@@ -54,32 +54,6 @@ func (h *InstanceHandler) exec(cmd *cobra.Command, args []string) (int, error) {
 	return e.Run(ctx)
 }
 
-func watchTermSize(ctx context.Context, s *StdStreams) <-chan *TerminalSize {
-	out := make(chan *TerminalSize)
-	go func() {
-		defer close(out)
-		sigCh := make(chan os.Signal, 1)
-		signal.Notify(sigCh, syscall.SIGWINCH)
-		for {
-			select {
-			case <-ctx.Done():
-				return
-			case <-sigCh:
-				termSize, err := GetTermSize(s.Stdout)
-				if err != nil {
-					continue
-				}
-				select {
-				case <-ctx.Done():
-					return
-				case out <- termSize:
-				}
-			}
-		}
-	}()
-	return out
-}
-
 // Disclaimer: parts of this file are either taken or largey inspired from Nomad's CLI
 // implementation (command/alloc_exec.go) or API implementation (api/allocations_exec.go)
 
@@ -445,15 +419,3 @@ func GetStdStreams() (*StdStreams, func() error, error) {
 	}
 	return stdStreams, resetTermState, nil
 }
-
-func GetTermSize(t io.Writer) (*TerminalSize, error) {
-	fd, isTerm := term.GetFdInfo(t)
-	if !isTerm {
-		return nil, errors.New("not a terminal")
-	}
-	ws, err := term.GetWinsize(fd)
-	if err != nil {
-		return nil, errors.Wrap(err, "cannot get winsize")
-	}
-	return &TerminalSize{Height: int32(ws.Height), Width: int32(ws.Width)}, nil
-}

pkg/koyeb/instances_exec_unix.go

@@ -0,0 +1,54 @@
+//go:build !windows
+// +build !windows
+
+package koyeb
+
+import (
+	"context"
+	"io"
+	"os"
+	"os/signal"
+	"syscall"
+
+	"github.com/moby/term"
+
+	"github.com/pkg/errors"
+)
+
+func watchTermSize(ctx context.Context, s *StdStreams) <-chan *TerminalSize {
+	out := make(chan *TerminalSize)
+	go func() {
+		defer close(out)
+		sigCh := make(chan os.Signal, 1)
+		signal.Notify(sigCh, syscall.SIGWINCH)
+		for {
+			select {
+			case <-ctx.Done():
+				return
+			case <-sigCh:
+				termSize, err := getTermSize(s.Stdout)
+				if err != nil {
+					continue
+				}
+				select {
+				case <-ctx.Done():
+					return
+				case out <- termSize:
+				}
+			}
+		}
+	}()
+	return out
+}
+
+func getTermSize(t io.Writer) (*TerminalSize, error) {
+	fd, isTerm := term.GetFdInfo(t)
+	if !isTerm {
+		return nil, errors.New("not a terminal")
+	}
+	ws, err := term.GetWinsize(fd)
+	if err != nil {
+		return nil, errors.Wrap(err, "cannot get winsize")
+	}
+	return &TerminalSize{Height: int32(ws.Height), Width: int32(ws.Width)}, nil
+}

pkg/koyeb/instances_exec_windows.go

@@ -0,0 +1,12 @@
+//go:build windows
+// +build windows
+
+package koyeb
+
+import (
+	"context"
+)
+
+func watchTermSize(ctx context.Context, s *StdStreams) <-chan *TerminalSize {
+	return nil
+}