ci: add ci to enfore conventional commit #529
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mengqiy
requested review from
droot,
frankfarzan and
phanimarupaka
as code owners
droot
approved these changes
Oct 14, 2021
Contributor
droot
left a comment
droot
left a comment
There was a problem hiding this comment.
The schema looks good to me. Lets implement it for kpt repo as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: conventional commit https://www.conventionalcommits.org/en/v1.0.0/#summary
We might want to leverage
release-please, using conventional commit is prerequisite. We should start to use it sooner than later. Even though we have not decided to userelease-please, it's still a good practice to use conventional commit.