iOS Plugin Loading

[Cubik65536]

Following this, I am still trying to make the dummy plugin working on iOS so I can start to port other plugins, however I found out that the plugin adding/setup seems just missing from the STTextViewUIKit, it is not possible to do addPlugin while using Storyboard and the plugin aren't really loaded when using SwiftUI (as addPlugin are not called?). Did I miss something?

[Cubik65536]

In the AppKit (macOS) version of STTextView, there are the following code for adding and setting-up plugins:

STTextView/Sources/STTextViewAppKit/STTextView.swift

Lines 1370 to 1402 in 8d5d376

	open func addPlugin(_ instance: any STPlugin) {
	let plugin = Plugin(instance: instance)
	plugins.append(plugin)
	// setup plugin right away if view is already setup
	if self.window != nil {
	setupPlugins()
	}
	}
	private func setupPlugins() {
	for (offset, plugin) in plugins.enumerated() where plugin.events == nil {
	// set events handler
	var plugin = plugin
	plugin.events = setUp(instance: plugin.instance)
	plugins[offset] = plugin
	}
	}
	@MainActor
	private func setUp(instance: some STPlugin) -> STPluginEvents {
	// unwrap any STPluginProtocol
	let events = STPluginEvents()
	instance.setUp(
	context: STPluginContext(
	coordinator: instance.makeCoordinator(context: .init(textView: self)),
	textView: self,
	events: events
	)
	)
	return events
	}
	}

After I added the same code of UIKit (iOS) source, it first didn't work. But, after I removed the self.window != nil check, the plugin adding/setup now works, and the dummy plugin is working (event handlers are executed).

The final added piece of code is:

open func addPlugin(_ instance: any STPlugin) {
    let plugin = Plugin(instance: instance)
    plugins.append(plugin)
    setupPlugins()
}

private func setupPlugins() {
    for (offset, plugin) in plugins.enumerated() where plugin.events == nil {
        // set events handler
        var plugin = plugin
        plugin.events = setUp(instance: plugin.instance)
        plugins[offset] = plugin
    }
}

@MainActor
private func setUp(instance: some STPlugin) -> STPluginEvents {
    // unwrap any STPluginProtocol
    let events = STPluginEvents()
    instance.setUp(
        context: STPluginContext(
            coordinator: instance.makeCoordinator(context: .init(textView: self)),
            textView: self,
            events: events
        )
    )
    return events
}

However, it seems that setupPlugins() will be called every time a new plugin is added, and I'm not sure if this is a wanted behaviour, or if something would break when setupPlugins is called when the view is not set up (adding only one plugin certainly works though).