[Feedback v2.0.0 (beta1) ] - performTextFinderAction feature seems broken

[paul1893]

Hello 👋,

If I'm not mistaken, STLineNumberRulerView has been replaced by a STGutterView view in v2.0.0 (beta 1). It is no longer a NSRulerView and so performTextFinderAction feature seems broken ? As NSPanel and position of search results are now wrong offset.

Enregistrement.de.l.ecran.2024-11-19.a.22.48.18.mov

[krzyzanowskim]

yes. It's the first thing to fix when I sit on it. unless you want to get a try on that?

[paul1893]

If you have it in mind, that's the main thing.
I'm not sure I'll find the time in the coming weeks to take a detailed look, but if I do, would you prefer me to open a PR?

To ensure we're synced about resolution strategy, would you prefer that STGutterView inherits from NSRulerView? (This is what I have in mind) or keeping STGutterView a standard NSView (I guess you made it for a reason) ?

[paul1893]

I've quickly jump on the subject this evening and got something that seems to work when making STGutterView a NSRulerView again 🤷‍♂️

stgutterview-nsrulerview.mov

[krzyzanowskim]

would you prefer that STGutterView inherits from NSRulerView?

I'd rather not. for many reasons, but dealing with NSRuleView turned out to be too limited - also not transferable to UIKit

[paul1893]

I'd rather not. ... also not transferable to UIKit

Ok, understood 👌

[paul1893]

Ok, so adding scrollView.contentInsets.left = gutterPadding in the STTextView.sizeToFit method and setting scrollView.automaticallyAdjustsContentInsets = false to avoid weird jumps when resizing the window seems to makes the job and let the STGutterView being a NSView untouched.

Enregistrement.de.l.ecran.Nov.22.2024.10h03.mov

[krzyzanowskim]

that's the thing! want to open PR with that change?

[paul1893]

Yes sure, here it is: #75

Don't hesitate to test it deeper. I'm not sure to know all about STTextView and side effect that I could have been introduced.

[krzyzanowskim]

Fixed on main branch now.

Screen.Recording.2024-12-15.at.19.20.06.mov