docs: correct directory and set entryPointStrategy #2216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
k8s-ci-robot
added
the
do-not-merge/invalid-commit-message
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
FYI - the bot does not like the commit message. |
The directory where to generate the docs from was wrong, I'm not sure when this changed but probably during the move from release-0.x to release-1.x. Also the `entryPointStrategy` needed to be set so that we are able to include these files to generate the docs even if our ts-config doesn't include them. This was the default behavior a couple of releases of typedoc ago but was changed.
k8s-ci-robot
removed
lgtm
Member
Author
|
@cjihrig thanks for the notification. |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjihrig, mstruebing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The directory where to generate the docs from was wrong, I'm not sure
when this changed but probably during the move from release-0.x to
release-1.x.
Also the
entryPointStrategyneeded to be set so that we are able toinclude these files to generate the docs even if our ts-config doesn't
include them.
This was the default behavior a couple of releases of typedoc ago but
was changed.
Closes #2209