Skip to content

Commit b9e33ae

Browse files
committed
Wrap errors
1 parent 889967b commit b9e33ae

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

pkg/os/iscsi/api.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ func New() APIImplementor {
2323
func (APIImplementor) AddTargetPortal(portal *TargetPortal) error {
2424
existing, err := cim.QueryISCSITargetPortal(portal.Address, portal.Port, nil)
2525
if cim.IgnoreNotFound(err) != nil {
26-
return err
26+
return fmt.Errorf("error query target portal at (%s:%d). err: %v", portal.Address, portal.Port, err)
2727
}
2828

2929
if existing != nil {
@@ -42,7 +42,7 @@ func (APIImplementor) AddTargetPortal(portal *TargetPortal) error {
4242
func (APIImplementor) DiscoverTargetPortal(portal *TargetPortal) ([]string, error) {
4343
targets, err := cim.ListISCSITargetsByTargetPortalAddressAndPort(portal.Address, portal.Port, nil)
4444
if err != nil {
45-
return nil, err
45+
return nil, fmt.Errorf("error list targets by target portal at (%s:%d). err: %v", portal.Address, portal.Port, err)
4646
}
4747

4848
var iqns []string
@@ -61,7 +61,7 @@ func (APIImplementor) DiscoverTargetPortal(portal *TargetPortal) ([]string, erro
6161
func (APIImplementor) ListTargetPortals() ([]TargetPortal, error) {
6262
instances, err := cim.ListISCSITargetPortals(cim.ISCSITargetPortalDefaultSelectorList)
6363
if err != nil {
64-
return nil, err
64+
return nil, fmt.Errorf("error list target portals. err: %v", err)
6565
}
6666

6767
var portals []TargetPortal
@@ -83,7 +83,7 @@ func (APIImplementor) ListTargetPortals() ([]TargetPortal, error) {
8383
func (APIImplementor) RemoveTargetPortal(portal *TargetPortal) error {
8484
instance, err := cim.QueryISCSITargetPortal(portal.Address, portal.Port, nil)
8585
if err != nil {
86-
return err
86+
return fmt.Errorf("error query target portal at (%s:%d). err: %v", portal.Address, portal.Port, err)
8787
}
8888

8989
result, err := cim.RemoveISCSITargetPortal(instance)
@@ -97,12 +97,12 @@ func (APIImplementor) RemoveTargetPortal(portal *TargetPortal) error {
9797
func (APIImplementor) ConnectTarget(portal *TargetPortal, iqn string, authType string, chapUser string, chapSecret string) error {
9898
target, err := cim.QueryISCSITarget(portal.Address, portal.Port, iqn)
9999
if err != nil {
100-
return err
100+
return fmt.Errorf("error query target %s from target portal at (%s:%d). err: %w", iqn, portal.Address, portal.Port, err)
101101
}
102102

103103
connected, err := cim.IsISCSITargetConnected(target)
104104
if err != nil {
105-
return err
105+
return fmt.Errorf("error query connected of target %s from target portal at (%s:%d). err: %w", iqn, portal.Address, portal.Port, err)
106106
}
107107

108108
if connected {
@@ -123,7 +123,7 @@ func (APIImplementor) ConnectTarget(portal *TargetPortal, iqn string, authType s
123123
func (APIImplementor) DisconnectTarget(portal *TargetPortal, iqn string) error {
124124
target, err := cim.QueryISCSITarget(portal.Address, portal.Port, iqn)
125125
if err != nil {
126-
return err
126+
return fmt.Errorf("error query target %s from target portal at (%s:%d). err: %w", iqn, portal.Address, portal.Port, err)
127127
}
128128

129129
connected, err := cim.IsISCSITargetConnected(target)
@@ -139,7 +139,7 @@ func (APIImplementor) DisconnectTarget(portal *TargetPortal, iqn string) error {
139139
// get session
140140
session, err := cim.QueryISCSISessionByTarget(target)
141141
if err != nil {
142-
return fmt.Errorf("error query session of target %s from target portal at (%s:%d). err: %w", iqn, portal.Address, portal.Port, err)
142+
return fmt.Errorf("error query session of target %s from target portal at (%s:%d). err: %w", iqn, portal.Address, portal.Port, err)
143143
}
144144

145145
sessionIdentifier, err := cim.GetISCSISessionIdentifier(session)
@@ -170,7 +170,7 @@ func (APIImplementor) DisconnectTarget(portal *TargetPortal, iqn string) error {
170170
func (APIImplementor) GetTargetDisks(portal *TargetPortal, iqn string) ([]string, error) {
171171
target, err := cim.QueryISCSITarget(portal.Address, portal.Port, iqn)
172172
if err != nil {
173-
return nil, err
173+
return nil, fmt.Errorf("error query target %s from target portal at (%s:%d). err: %w", iqn, portal.Address, portal.Port, err)
174174
}
175175

176176
connected, err := cim.IsISCSITargetConnected(target)

0 commit comments

Comments
 (0)