Skip to content

Add tests for ControllerServer.GetSnapshot #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Add tests for ControllerServer.GetSnapshot #573

wants to merge 4 commits into from
+2,220 −1,375

Conversation

nixpanic
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:

GetSnapshot is a new CSI procedure for the ControllerServer.

Special notes for your reviewer:

/cc xing-yang

Reason for DRAFT: There is no release of the CSI spec with GetSnapshot yet, so this vendors the master branch of the spec and protobuf package.

Some files had to be re-generated, GoMock has moved to an other home. Those changes are included here too.

Does this PR introduce a user-facing change?:

Add CSI sanity testing of ControllerServer.GetSnapshot.

@k8s-ci-robot k8s-ci-robot requested a review from xing-yang May 26, 2025 15:47
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 26, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nixpanic
Once this PR has been reviewed and has the lgtm label, please assign xing-yang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 26, 2025
@nixpanic
Copy link
Member Author

/test all

Checking to see if nothing broke.

@nixpanic
Copy link
Member Author

/test pull-kubernetes-csi-csi-test

Now with a hostpath driver that supports GetSnapshot

@nixpanic
Copy link
Member Author

/test pull-kubernetes-csi-csi-test

Fixed the "expect an error on invalid snapshod-id" test.

@nixpanic
Copy link
Member Author

/test pull-kubernetes-csi-csi-test

Now including updated release-tools which contain Go 1.24.2.

nixpanic added 3 commits May 28, 2025 10:08
@nixpanic
Squashed 'release-tools/' changes from 90efb2c..f5fec3e
6993dde 
f5fec3e Merge pull request kubernetes-csi#275 from chrishenzie/emeritus
c5d285d Remove chrishenzie from kubernetes-csi-reviewers
0a435bf Merge pull request kubernetes-csi#274 from andyzhangx/patch-5
cd7b4bb Bump golang to 1.24.2 to fix CVE-2025-22871
701dc34 Merge pull request kubernetes-csi#273 from andyzhangx/patch-4
aeebd30 Bump golang to 1.24.0
f277d56 Merge pull request kubernetes-csi#270 from carlory/update-kind-version
6dcb96a update default kind version to v0.25.0

git-subtree-dir: release-tools
git-subtree-split: f5fec3e364ddcdd060e7b7f22a04032556d194fb
@nixpanic
Update release-tools to get Go 1.24
c59f46d 
Go 1.24 is required to build the latest csi-driver-hostpath.
@nixpanic
[DO NOT MERGE] use csi-driver-hostpath with GetSnapshot support
b1cb356
@nixpanic
Copy link
Member Author

/test pull-kubernetes-csi-csi-test

Clean(er) release-tools update 🤞

@nixpanic nixpanic mentioned this pull request May 28, 2025
Draft
nixpanic added a commit to nixpanic/csi-driver-host-path that referenced this pull request Jun 12, 2025
@nixpanic
[TESTING] use csi-test with GetSnapshot support
e7c67c6 
Repoository and branch are the source of PR
kubernetes-csi/csi-test#573
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 26, 2025
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nixpanic @k8s-ci-robot @k8s-triage-robot