Serve metrics & pprof via CSIMetricsManager#1347
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrewSirenko The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
|
@k8s-triage-robot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
We recently updated csi-lib-utils to serve additional registries via PR kubernetes-csi/csi-lib-utils#189 so that all sidecars can easily serve leader, work queue, process, and Go runtime metrics via Kubernetes legacymetrics.
This PR refactors the provisioner to
Tested:
See gist: https://gist.github.com/AndrewSirenko/2d3bcd1cbc47541cab4f4fae9561fec0
Built all sidecar, deployed alongside EBS CSI Driver v1.40. Saw new metrics when scraping each sidecar /metrics endpoint.
Also tested upgrade case: No errors when upgrading EBS CSI Driver via helm from revision with default sidecars to these custom sidecars.
Excercised dynamic provisioning, snapshot, resize, and modify workflows. No errors. Workqueue metrics increased.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: