Add node daemonset updateStrategy to helmchart

[NeonWizard]

Is this a bug fix or adding new feature?
Feature

What is this PR about? / Why do we need it?
#410

What testing is done?
Modified helmchart locally, deployed to cluster with custom updateStrategy

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: NeonWizard / name: Wes (450b926)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: NeonWizard
Once this PR has been reviewed and has the lgtm label, please assign olemarkus for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @NeonWizard!

It looks like this is your first PR to kubernetes-sigs/aws-fsx-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-fsx-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @NeonWizard. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[NeonWizard]

Hi @torredil and @wongma7, apologies on the delay with getting the CLA signed, but this should be good to go now! Could I get an estimation on when you might be able to get this PR moving? Thank you

[kuba-wolf]

Hi @NeonWizard can you squash the 3 commits into a singular commit?

[NeonWizard]

Hi @NeonWizard can you squash the 3 commits into a singular commit?

Sure, let me also update the changelog

[kuba-wolf]

Hi @NeonWizard can you squash the 3 commits into a singular commit?

Sure, let me also update the changelog

If you're going to update the changelog you should also update the helm chart to create a new helm version. See here for an example: #378

[NeonWizard]

Hi @NeonWizard can you squash the 3 commits into a singular commit?

Sure, let me also update the changelog

If you're going to update the changelog you should also update the helm chart to create a new helm version. See here for an example: #378

Updated!

[kuba-wolf]

/ok-to-test

[NeonWizard]

/retest

[kuba-wolf]

Hi @NeonWizard, We're doing a new release today which will involve a new helm chart. Just for simplicity, we won't be pulling this in, so the helm chart version will be outdated in this PR. We have another candidate helm chart change from another contributor, if you remove the helm chart version specific changes we can make a new helm chart release with both of your changes. Thanks for being patient, sorry for the confusion

[NeonWizard]

Hi @NeonWizard, We're doing a new release today which will involve a new helm chart. Just for simplicity, we won't be pulling this in, so the helm chart version will be outdated in this PR. We have another candidate helm chart change from another contributor, if you remove the helm chart version specific changes we can make a new helm chart release with both of your changes. Thanks for being patient, sorry for the confusion

Sounds good! I'll have that pushed shortly

[NeonWizard]

/retest

[NeonWizard]

Hey @kuba-wolf, the E2E tests seem to be repeatedly failing for unrelated errors. Could you take a look? And do you have an ETA on when we can get this released? Thanks

[kuba-wolf]

Hi @NeonWizard, I recently left AWS. Sorry for not getting to this while I was there, it ended up being a very busy wrap up.

Error: master-us-west-2a.spec.image: Invalid value: "099720109477/ubuntu/images/hvm-ssd/ubuntu-focal-20.04-amd64-server-20250429": image specified is invalid: "099720109477/ubuntu/images/hvm-ssd/ubuntu-focal-20.04-amd64-server-20250429"

It seems to me like the ami that was being used is no longer accessible, a new one needs to be pinned. Long term the goal should be to move off pinning the ami altogether.

/assign @khoang98

[NeonWizard]

Hi @khoang98, could I get an ETA on this please? The E2E tests also seem to be having an infra failure if you could help look into that. Thank you

[khoang98]

/test pull-aws-fsx-csi-driver-e2e

[khoang98]

I'm not seeing any pinned ubuntu AMIs in our e2e framework - suspecting that https://github.com/kubernetes/kops/pull/17444/files might help w this

[NeonWizard]

/retest

[NeonWizard]

/retest

[k8s-ci-robot]

@NeonWizard: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-aws-fsx-csi-driver-e2e	450b926	link	true	/test pull-aws-fsx-csi-driver-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[khoang98]

I'm working on bumping our e2e dependencies in a different PR to use a more recent version of kops - seeing some test failures as a result. This is WIP