fix: adjust the batch size as per the number of disks allowed

[nearora-msft]

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

• uses conventional commit messages
• includes documentation
• adds unit tests
• tested upgrade from previous version

Special notes for your reviewer:

Release note:

none

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[nearora-msft]

/test all

[andyzhangx]

thanks for the PR, I have left some comments.

[andyzhangx]

btw, the original Elastic issue is mainly contributed by retry-after value returned by CRP during polling, this MaximumDataDisksExceeded error still happens some times, and from the CRP logs, I could see the next VMScaleSetVMs.VMScaleSetVMsOperation.PUT would succeed very soon in a few seconds, that means it could recover very soon.

On the other hand, I think this PR is still valuable which could make most disk attach succeed in the beginning. Thanks for the fix.

[nearora-msft]

/retest

[andyzhangx]

/retest

[andyzhangx]

can you add ut for returned bool value check in another PR? thx

[andyzhangx]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, nearora-msft

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [andyzhangx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andyzhangx]

/cherrypick release-1.32

[andyzhangx]

/cherrypick release-1.31

[k8s-infra-cherrypick-robot]

@andyzhangx: #3039 failed to apply on top of branch "release-1.31":

Applying: fix: remove disks from the batch if it exceeds maxdatadisks limit
Applying: Revert "fix: wait for detach disk finish first"
Using index info to reconstruct a base tree...
M	pkg/azuredisk/azure_controller_common.go
M	pkg/azuredisk/azure_controller_common_test.go
M	pkg/azuredisk/azuredisk.go
M	pkg/azuredisk/controllerserver.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/azuredisk/controllerserver.go
Auto-merging pkg/azuredisk/azuredisk.go
Auto-merging pkg/azuredisk/azure_controller_common_test.go
Auto-merging pkg/azuredisk/azure_controller_common.go
Applying: address review comments
Using index info to reconstruct a base tree...
M	pkg/azuredisk/azure_controller_common.go
M	pkg/azuredisk/azuredisk.go
M	pkg/azuredisk/controllerserver.go
M	pkg/azuredisk/nodeserver.go
M	pkg/azuredisk/nodeserver_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/azuredisk/nodeserver_test.go
Auto-merging pkg/azuredisk/nodeserver.go
Auto-merging pkg/azuredisk/controllerserver.go
Auto-merging pkg/azuredisk/azuredisk.go
Auto-merging pkg/azuredisk/azure_controller_common.go
CONFLICT (content): Merge conflict in pkg/azuredisk/azure_controller_common.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0003 address review comments

In response to this:

/cherrypick release-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@andyzhangx: new pull request created: #3073

In response to this:

/cherrypick release-1.32

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.