Skip to content

Drop Equinix Metal Load Balancer #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tylerauerbeck
Copy link
Contributor

As the Equinix Metal Load Balancer service has been sunset -- this removes the EMLB configurations that were put in place to support this feature from CPEM.

Signed-off-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tylerauerbeck
Once this PR has been reviewed and has the lgtm label, please assign cheftako for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 21, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @tylerauerbeck!

It looks like this is your first PR to kubernetes-sigs/cloud-provider-equinix-metal 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cloud-provider-equinix-metal has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 21, 2025
@displague
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2025
@displague
Copy link
Member

displague commented Mar 31, 2025

"lgtm" was to get PROW unblocked. (which may not be enough, the job may only run on merge and origin branches)

I have concerns about this PR, and I can't give it the review it deserves.

This will be hard to test since the service has been sunset.

Even if we ignore that, we should consider side effects on users who have previously deployed a load balancer through CPEM (even if the underlying instance is gone). If this is impractical, we can smooth over gaps with documentation in the release notes and README.md: "if you had X, here's how to unwind it before you update to a post-lbaas CPEM".

The best case is to offer a migration guide, but contributor and reviewer constraints prevent that.

One thing to consider is whether Services or other resources managed through this CPEM LBaaS code were assigned finalizers or other configuration options that will need to be manually removed in the absence of the supporting controller code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants