-
Notifications
You must be signed in to change notification settings - Fork 92
✨ 🌱 Make configSecret configurable per component #780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
✨ 🌱 Make configSecret configurable per component #780
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @rbjorklin. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/ok-to-test |
This makes it so that each component can be configured individually. By making the configuration component specific it is more clear which component is actually using it. This also breaks out a common section into a helper which reduces duplication.
cc90a8d
to
23e7903
Compare
@rbjorklin Thanks for this. Following the same idea, can you add |
|
What this PR does / why we need it:
This builds on the extensibility introduced in #638.
configSecret
and the component/provider using said config clearer.configSecret
logic across templates by moving it into a helper.This has been implemented in such a way that it is backwards compatible and will default to the existing behaviour. If you want to use the new behaviour you would have to do something like this:
while also removing the
configSecret
key at the root level of thevalues.yaml
file.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #