Skip to content

✨ Only manage security groups for ENIs tagged by CAPA #5813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fiunchinho wants to merge 1 commit into
base: main
Choose a base branch
from
Open

✨ Only manage security groups for ENIs tagged by CAPA #5813

fiunchinho wants to merge 1 commit into from
+287 −0

Conversation

@fiunchinho
Copy link
Contributor

@fiunchinho fiunchinho commented Jan 13, 2026

What type of PR is this?

/kind feature

What this PR does / why we need it:

We don't want CAPA managing the security groups of the ENIs created by other components, like cilium.

Checklist:

  • squashed commits
  • includes documentation
  • includes emoji in title
  • adds unit tests
  • adds or updates e2e tests

Release note:

Only manage security groups for ENIs tagged by CAPA

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 13, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nrb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 13, 2026
@fiunchinho fiunchinho changed the title Only manage security groups for ENIs tagged by CAPA ✨ Only manage security groups for ENIs tagged by CAPA Jan 13, 2026
@fiunchinho
Copy link
Contributor Author

fiunchinho commented Jan 13, 2026

/retest

@fiunchinho
Copy link
Contributor Author

fiunchinho commented Jan 13, 2026

/retest

1 similar comment
@fiunchinho
Copy link
Contributor Author

fiunchinho commented Jan 13, 2026

/retest

@fiunchinho
Copy link
Contributor Author

fiunchinho commented Jan 13, 2026

/test ?

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 13, 2026

@fiunchinho: The following commands are available to trigger required jobs:

/test pull-cluster-api-provider-aws-build

/test pull-cluster-api-provider-aws-build-docker

/test pull-cluster-api-provider-aws-e2e-blocking

/test pull-cluster-api-provider-aws-test

/test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

/test pull-cluster-api-provider-aws-apidiff-main

/test pull-cluster-api-provider-aws-e2e

/test pull-cluster-api-provider-aws-e2e-clusterclass

/test pull-cluster-api-provider-aws-e2e-conformance

/test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts

/test pull-cluster-api-provider-aws-e2e-eks

/test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-provider-aws-apidiff-main

pull-cluster-api-provider-aws-build

pull-cluster-api-provider-aws-build-docker

pull-cluster-api-provider-aws-e2e-blocking

pull-cluster-api-provider-aws-test

pull-cluster-api-provider-aws-verify
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fiunchinho
Copy link
Contributor Author

fiunchinho commented Jan 13, 2026

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

@fiunchinho
Copy link
Contributor Author

fiunchinho commented Jan 13, 2026

/retest

1 similar comment
@fiunchinho
Copy link
Contributor Author

fiunchinho commented Jan 13, 2026

/retest

@fiunchinho fiunchinho moved this to Blocked / Waiting ⛔️ in Roadmap Jan 14, 2026
@fiunchinho
Copy link
Contributor Author

fiunchinho commented Jan 19, 2026

/retest

@fiunchinho
Copy link
Contributor Author

fiunchinho commented Jan 19, 2026

/test pull-cluster-api-provider-aws-e2e-blocking

@fiunchinho
Copy link
Contributor Author

fiunchinho commented Jan 19, 2026

/test pull-cluster-api-provider-aws-e2e-eks

3 similar comments
@fiunchinho
Copy link
Contributor Author

fiunchinho commented Jan 20, 2026

/test pull-cluster-api-provider-aws-e2e-eks

@fiunchinho
Copy link
Contributor Author

fiunchinho commented Jan 20, 2026

/test pull-cluster-api-provider-aws-e2e-eks

@fiunchinho
Copy link
Contributor Author

fiunchinho commented Jan 20, 2026

/test pull-cluster-api-provider-aws-e2e-eks

@fiunchinho
Copy link
Contributor Author

fiunchinho commented Jan 21, 2026

/retest

@fiunchinho
Copy link
Contributor Author

fiunchinho commented Jan 29, 2026

/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e-eks

AndiDog
AndiDog reviewed Jan 29, 2026
View reviewed changes
Copy link
Contributor

@AndiDog AndiDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 29, 2026

LGTM label has been added.

DetailsGit tree hash: 6a2e76a7bc4315885017f710b7728e4e35b51d97

@fiunchinho
Copy link
Contributor Author

fiunchinho commented Jan 29, 2026

/retest

1 similar comment
@fiunchinho
Copy link
Contributor Author

fiunchinho commented Feb 2, 2026

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 2, 2026 •
edited
Loading

@fiunchinho: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-aws-e2e 7ac62a8 link false /test pull-cluster-api-provider-aws-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndiDog AndiDog AndiDog left review comments

@damdo damdo Awaiting requested review from damdo

@dlipovetsky dlipovetsky Awaiting requested review from dlipovetsky

Assignees

@AndiDog AndiDog

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fiunchinho @k8s-ci-robot @AndiDog