Skip to content

Update Calico to 3.29 #5499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

jsturtevant
Copy link
Contributor

@jsturtevant jsturtevant commented Mar 21, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
fixes #5498

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • cherry-pick candidate

Release note:

Update default calico version to 3.29.2

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 21, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign timothysc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 21, 2025
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 21, 2025
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.57%. Comparing base (f0f36c7) to head (4395620).
Report is 26 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5499   +/-   ##
=======================================
  Coverage   52.57%   52.57%           
=======================================
  Files         272      272           
  Lines       29470    29470           
=======================================
  Hits        15495    15495           
  Misses      13167    13167           
  Partials      808      808           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 21, 2025
@nawazkh
Copy link
Member

nawazkh commented Mar 21, 2025

/test pull-cluster-api-provider-azure-conformance-dual-stack-with-ci-artifacts

@jsturtevant
Copy link
Contributor Author

took a look at the windows nodes and they are not getting correct calico version. Will need to look closer at how that version is specified

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
@jsturtevant
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-ci-entrypoint

1 similar comment
@jsturtevant
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-ci-entrypoint

Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
@k8s-ci-robot
Copy link
Contributor

@jsturtevant: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-e2e 4395620 link true /test pull-cluster-api-provider-azure-e2e
pull-cluster-api-provider-azure-ci-entrypoint 4395620 link true /test pull-cluster-api-provider-azure-ci-entrypoint

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jsturtevant
Copy link
Contributor Author

Getting closer, the pods are deploying. Now I believe we are running into kubernetes-sigs/sig-windows-tools#347

@jsturtevant
Copy link
Contributor Author

/close
in favor of #5523

@k8s-ci-robot
Copy link
Contributor

@jsturtevant: Closed this PR.

In response to this:

/close
in favor of #5523

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-project-automation github-project-automation bot moved this from Todo to Done in CAPZ Planning Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update the Calico version for testing
3 participants