Skip to content

Add verify-go-directive check from core CAPI #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add verify-go-directive check from core CAPI #1549

wants to merge 1 commit into from
+8 −1

Conversation

@damdo
Copy link
Member

@damdo damdo commented Oct 23, 2025

What type of PR is this?
/kind other

What this PR does / why we need it:
Same reason as: kubernetes-sigs/cluster-api#10258

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 23, 2025
@k8s-ci-robot
Copy link
Contributor

@damdo: The label(s) kind/other cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?
/kind other

What this PR does / why we need it:
Same reason as: kubernetes-sigs/cluster-api#10258

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@damdo damdo requested a review from justinsb October 23, 2025 10:46
@netlify
Copy link

netlify bot commented Oct 23, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name Link
🔨 Latest commit 6f5cc6e
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-gcp/deploys/68fa07884fea4a0008c27665
😎 Deploy Preview https://deploy-preview-1549--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 23, 2025
@k8s-ci-robot k8s-ci-robot requested a review from dims October 23, 2025 10:46
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 23, 2025
@damdo
Copy link
Member Author

damdo commented Oct 23, 2025

/assign @justinsb @salasberryfin

This is used in CAPI upstream and checks the go.mod directive is in concert with the desired one specified in the Makefile.
Sounds like a solution to the common CAPI problem and go bumping strategy we discussed here: #1515

@damdo
Copy link
Member Author

damdo commented Oct 23, 2025

cc. @chrischdi

chrischdi
chrischdi reviewed Oct 23, 2025
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you

/lgtm
/hold

Makefile
verify-go-directive:
# use the core Cluster API script directly to verify the go directive matches the desired one.
# ref: https://github.com/kubernetes-sigs/cluster-api/blob/v1.10.7/hack/verify-go-directive.sh
curl --retry $(CURL_RETRIES) -fsL https://raw.githubusercontent.com/kubernetes-sigs/cluster-api/refs/tags/v1.11.0/hack/verify-go-directive.sh | bash -s -- -g $(GOLANG_DIRECTIVE_VERSION)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'd copy over that script instead of relying on curl, maybe could hit rate limits or flake due to other things, but up to you)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer not to maintain that also over here TBH
If we see issues with curl we might want to revisit :)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinsb justinsb Awaiting requested review from justinsb

@dims dims Awaiting requested review from dims

@salasberryfin salasberryfin Awaiting requested review from salasberryfin

1 more reviewer

@chrischdi chrischdi chrischdi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@justinsb justinsb

@chrischdi chrischdi

@salasberryfin salasberryfin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@damdo @k8s-ci-robot @chrischdi @justinsb @salasberryfin