Proposal to use tags for tracking PowerVS cluster resources #2364

arshadd-b · 2025-05-20T08:00:49Z

What this PR does / why we need it:
Proposal for adding the tags to PowerVS Cluster resources and performing delete of resources on the bases of tags
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/area provider/ibmcloud

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Add tags to PowerVS Cluster resources and delete resources based on tags

k8s-ci-robot · 2025-05-20T08:00:55Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arshadd-b
Once this PR has been reviewed and has the lgtm label, please assign prajyot-parab for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2025-05-20T08:00:58Z

Hi @arshadd-b. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

netlify · 2025-05-20T08:03:04Z

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name	Link
🔨 Latest commit	`14da794`
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-cluster-api-ibmcloud/deploys/684fd89ead7e920008fbc82a
😎 Deploy Preview	https://deploy-preview-2364.cluster-api-ibmcloud.sigs.k8s.io
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Amulyam24 · 2025-05-20T08:56:39Z

/ok-to-test

Amulyam24 · 2025-05-22T07:21:40Z

/retitle Proposal to use tags for tracking PowerVS cluster resources

Karthik-K-N

In the delete flow diagram, I think If is not needed inside the rhombus as its already a decision block
In create flow diagram I think you missed to consider COSInstance

Karthik-K-N

Thanks for the PR, Most of the things are good,lets update it bit more to make it better.

docs/proposal/controller-and-user-tags.md

arshadd-b · 2025-05-30T10:22:05Z

In the delete flow diagram, I think If is not needed inside the rhombus as its already a decision block In create flow diagram I think you missed to consider COSInstance

done

Amulyam24

Hi @arshadd-b, Thank you for the proposal!

I'm not clear on how user tags will be used apart from the controller tag. Can you please share more details on it?

arshadd-b · 2025-06-11T14:25:23Z

Hi @arshadd-b, Thank you for the proposal!

I'm not clear on how user tags will be used apart from the controller tag. Can you please share more details on it?

Hi @Amulyam24 , It is the same functionality that we do from UI, adding tags to IBM Cloud resources if user wants to tag resources. It can help to user in resource management.

Amulyam24

Hi @Amulyam24 , It is the same functionality that we do from UI, adding tags to IBM Cloud resources if user wants to tag resources. It can help to user in resource management.

Got it, Thanks for the clarification.

A couple of suggestions have been added.

In the create flow diagram, how about we enhance the condition such as cluster.spec.UserTags > 0 , then proceed to attach user provided tags.

docs/proposal/controller-and-user-tags.md

Amulyam24 · 2025-06-12T09:44:32Z

docs/proposal/controller-and-user-tags.md

+- Currently TransitGateway Connections doesn't support tagging, So we will handle deletion of connections based on VPC.
+- DHCP Server doesn't support tagging, So we will tag DHCP Network and handle deletion based on Network.


Suggested change

- Currently TransitGateway Connections doesn't support tagging, So we will handle deletion of connections based on VPC.

- DHCP Server doesn't support tagging, So we will tag DHCP Network and handle deletion based on Network.

Currently transit gateway connections and DHCP server don't support tagging. We will handle their deletion using the VPC and network tag respectively.

When DHCP server is created, we use its network right, is that taggable?

should we depend on workspace resource tag instead?

cc @Karthik-K-N

@Amulyam24 Actually there is ause case when workspace is already created but DHCP network is newly created,
in that case we want to delete the network only not workspace. So for this case we have to tag the network.
I have already checked for network tagging is supported .

docs/proposal/controller-and-user-tags.md

Amulyam24 · 2025-06-12T09:56:43Z

docs/proposal/controller-and-user-tags.md

+// IBMPowerVSClusterSpec defines the desired state of IBMPowerVSCluster.
+type IBMPowerVSClusterSpec struct {
+
+	// UserTags contains list of tags needs to be applied on resources


Suggested change

// UserTags contains list of tags needs to be applied on resources

// UserTags contains list of tags needs to be attached to resources

Will the user provided tags be attached to all the cluster resources?

Yes User tags will be added to all the cluster resources

docs/proposal/controller-and-user-tags.md

arshadd-b · 2025-06-16T08:43:02Z

Hi @Amulyam24 , It is the same functionality that we do from UI, adding tags to IBM Cloud resources if user wants to tag resources. It can help to user in resource management.

Got it, Thanks for the clarification.

A couple of suggestions have been added.

In the create flow diagram, how about we enhance the condition such as cluster.spec.UserTags > 0 , then proceed to attach user provided tags.

Updated the flow diagram

tags proposal

dcf0feb

k8s-ci-robot added the area/provider/ibmcloud Issues or PRs related to ibmcloud provider label May 20, 2025

k8s-ci-robot requested a review from Karthik-K-N May 20, 2025 08:00

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 20, 2025

k8s-ci-robot requested a review from Prajyot-Parab May 20, 2025 08:00

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 20, 2025

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 20, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 20, 2025

k8s-ci-robot changed the title ~~Add tags to PowerVS Cluster resources and delete resources based on tags~~ Proposal to use tags for tracking PowerVS cluster resources May 22, 2025

Karthik-K-N reviewed May 22, 2025

View reviewed changes

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 29, 2025

arshadd-b force-pushed the add-tags-proposal branch from 48c48f4 to e0b2d89 Compare May 29, 2025 13:48

arshadd-b requested a review from Karthik-K-N May 30, 2025 10:22

arshadd-b force-pushed the add-tags-proposal branch from e0b2d89 to d862267 Compare May 30, 2025 13:24

address review comments

0f4cb6b

arshadd-b force-pushed the add-tags-proposal branch from d862267 to 0f4cb6b Compare May 30, 2025 13:29

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 30, 2025

Amulyam24 reviewed Jun 5, 2025

View reviewed changes

arshadd-b requested a review from Amulyam24 June 11, 2025 14:25

Amulyam24 reviewed Jun 12, 2025

View reviewed changes

address review comments

14da794

arshadd-b force-pushed the add-tags-proposal branch from c7fec6b to 14da794 Compare June 16, 2025 08:41

arshadd-b requested a review from Amulyam24 June 17, 2025 14:07

		- Currently TransitGateway Connections doesn't support tagging, So we will handle deletion of connections based on VPC.
		- DHCP Server doesn't support tagging, So we will tag DHCP Network and handle deletion based on Network.

	- Currently TransitGateway Connections doesn't support tagging, So we will handle deletion of connections based on VPC.
	- DHCP Server doesn't support tagging, So we will tag DHCP Network and handle deletion based on Network.
	Currently transit gateway connections and DHCP server don't support tagging. We will handle their deletion using the VPC and network tag respectively.

	// UserTags contains list of tags needs to be applied on resources
	// UserTags contains list of tags needs to be attached to resources

Proposal to use tags for tracking PowerVS cluster resources #2364

Are you sure you want to change the base?

Proposal to use tags for tracking PowerVS cluster resources #2364

Uh oh!

Conversation

arshadd-b commented May 20, 2025

Uh oh!

k8s-ci-robot commented May 20, 2025

Uh oh!

k8s-ci-robot commented May 20, 2025

Uh oh!

netlify bot commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Uh oh!

Amulyam24 commented May 20, 2025

Uh oh!

Amulyam24 commented May 22, 2025

Uh oh!

Karthik-K-N left a comment

Choose a reason for hiding this comment

Uh oh!

Karthik-K-N left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

arshadd-b commented May 30, 2025

Uh oh!

Amulyam24 left a comment

Choose a reason for hiding this comment

Uh oh!

arshadd-b commented Jun 11, 2025

Uh oh!

Amulyam24 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Amulyam24 Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

arshadd-b Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Amulyam24 Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

arshadd-b Jun 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

arshadd-b commented Jun 16, 2025

Uh oh!

Uh oh!

netlify bot commented May 20, 2025 •

edited

Loading