-
Notifications
You must be signed in to change notification settings - Fork 89
⚠️ Adopt CAPI v1beta2 api's #2383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
/hold for testing |
Normal PowerVS Cluster testing results
From workload cluster
|
PowerVS Cluster creation with Infra creation flow
From workload cluster
|
VPC cluster creation with image 1.32.3
|
@mkumatag @Prajyot-Parab this PR is ready for review and we have tested various cluster creation flow as well. I think since we are updating to alpha version, Can we cut a patch release of CAPIBM prior to that if anyone wants to use few of the latest features we added like |
I think we need to be cautious about who consumes this. We can't guarantee that any changes in this alpha release will remain unchanged - they are subject to change or removal. This is intended for testing purposes only. |
PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Karthik-K-N! LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Karthik-K-N Missed - hack/ccm/Makefile#L16
This we will update while updating the CCM image, I think this is uses to build the CCM and its still in 1.23 |
/unhold |
@Karthik-K-N: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Karthik-K-N, Prajyot-Parab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR updates cluster-api version to v1.11.0-alpha.0
As a part of this upgrade the CORE CAPI resource version are updated to v1beta2, In controller as well in cluster creation templates.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes ##2375 #2387
Special notes for your reviewer:
/area provider/ibmcloud
Release note:
Test following cluster creation flow