-
Notifications
You must be signed in to change notification settings - Fork 89
⚠️ Adjust import alias to align with CAPI migration recommendation #2393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Adjust import alias to align with CAPI migration recommendation #2393
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
4cc71c3
to
5a79679
Compare
/hold for one round of testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
5a79679
to
7a80174
Compare
Tested a PowerVS Cluster creation flow and working as expected, machines are provisioned
|
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Amulyam24, Karthik-K-N, Prajyot-Parab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR does following things
Adjust import alias to align with CAPI migration recommendation
Reference: https://github.com/kubernetes-sigs/cluster-api/blob/9a7f9013d7e4ccb183203d11baf022d435f72bec/docs/book/src/developer/providers/migrations/v1.10-to-v1.11.md#how-to-bump-to-capi-v111-but-keep-using-deprecated-v1beta1-conditions
There were few accidental API spec changes in PR, This PR reverts it back.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
/area provider/ibmcloud
Release note: