Skip to content

⚠️ Adjust import alias to align with CAPI migration recommendation #2393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2025

Conversation

Karthik-K-N
Copy link
Contributor

@Karthik-K-N Karthik-K-N commented Jun 18, 2025

What this PR does / why we need it:

This PR does following things

  1. Adjust import alias to align with CAPI migration recommendation
    Reference: https://github.com/kubernetes-sigs/cluster-api/blob/9a7f9013d7e4ccb183203d11baf022d435f72bec/docs/book/src/developer/providers/migrations/v1.10-to-v1.11.md#how-to-bump-to-capi-v111-but-keep-using-deprecated-v1beta1-conditions

  2. There were few accidental API spec changes in PR, This PR reverts it back.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Adjust import alias to align with CAPI migration recommendation

@k8s-ci-robot k8s-ci-robot added the area/provider/ibmcloud Issues or PRs related to ibmcloud provider label Jun 18, 2025
Copy link

netlify bot commented Jun 18, 2025

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 7a80174
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-ibmcloud/deploys/68539c96dfbd78000894d99c
😎 Deploy Preview https://deploy-preview-2393.cluster-api-ibmcloud.sigs.k8s.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 18, 2025
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 18, 2025
@Karthik-K-N Karthik-K-N force-pushed the update-import-aliase branch from 4cc71c3 to 5a79679 Compare June 18, 2025 17:15
@Karthik-K-N
Copy link
Contributor Author

/hold for one round of testing

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2025
Copy link
Contributor

@Amulyam24 Amulyam24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2025
@Karthik-K-N Karthik-K-N force-pushed the update-import-aliase branch from 5a79679 to 7a80174 Compare June 19, 2025 05:13
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2025
@Karthik-K-N
Copy link
Contributor Author

Karthik-K-N commented Jun 19, 2025

Tested a PowerVS Cluster creation flow and working as expected, machines are provisioned

karthikkn@Karthiks-MacBook-Pro cluster-api-provider-ibmcloud % kubectl get machines
NAME                                         CLUSTER                  NODENAME                                     PROVIDERID                                                                                         PHASE         AGE   VERSION
karthikkn-capi-powervs-control-plane-fmwlb   karthikkn-capi-powervs   karthikkn-capi-powervs-control-plane-fmwlb   ibmpowervs://osa/osa21/398f55b0-9e00-4d5f-a42f-86124c65dfdf/4b934898-280a-45a7-8118-44dcf1c3a843   Running       41m   v1.32.3
karthikkn-capi-powervs-control-plane-p6nqn   karthikkn-capi-powervs   karthikkn-capi-powervs-control-plane-p6nqn   ibmpowervs://osa/osa21/398f55b0-9e00-4d5f-a42f-86124c65dfdf/846871cb-e6db-4ba0-871b-6149d2bd4a18   Running       89m   v1.32.3
karthikkn-capi-powervs-control-plane-tjfws   karthikkn-capi-powervs   karthikkn-capi-powervs-control-plane-tjfws   ibmpowervs://osa/osa21/398f55b0-9e00-4d5f-a42f-86124c65dfdf/aed22c18-32d3-4d09-bc25-7feee626f78b   Running       56m   v1.32.3

@Karthik-K-N
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2025
Copy link
Contributor

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amulyam24, Karthik-K-N, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit 48aebb9 into kubernetes-sigs:main Jun 19, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants