🌱 Test ORC upgrades in e2e #2601
Conversation
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
do-not-merge/work-in-progress
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/M
|
Hi @sirpaleet. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test ? |
|
@sirpaleet: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
|
||
| resources: | ||
| # latest stable release of major version v1.0 | ||
| - https://github.com/k-orc/openstack-resource-controller/releases/download/{go://github.com/k-orc/openstack-resource-controller@v1.0}/install.yaml |
There was a problem hiding this comment.
I think we have to put the version hard-coded here. The {go://...} syntax only works in the e2e config
There was a problem hiding this comment.
Would it be better to also hard-code the name in e2e_conf.yaml and in clusterctl_upgrade_test.go files so that there would be no confusion of the versions used in the future? This would most likely need some additional thought on error handling as well.
There was a problem hiding this comment.
Missed your other comment, my bad
|
/test ? |
|
@sirpaleet: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
test/e2e/data/e2e_conf.yaml
Outdated
| @@ -154,6 +154,15 @@ providers: | |||
| replacements: | |||
| - old: "imagePullPolicy: Always" | |||
| new: "imagePullPolicy: IfNotPresent" | |||
| # This is only for clusterctl upgrade tests, latest stable release of major version v1.0 | |||
| - name: "{go://github.com/k-orc/openstack-resource-controller@v1.0}" | |||
There was a problem hiding this comment.
Since we anyway have to hard-code the version in the kustomization, I would suggest hard-coding here also. Otherwise it will be confusing when the name is automatically updated but the actually installed version stays the same
|
The relevant test for the upgrade is pull-cluster-api-provider-openstack-e2e-full-test when you feel ready 🙂 |
Signed-off-by: Siiri Kemppainen <siiri.kemppainen@est.tech>
sirpaleet
force-pushed
the
siiri/orc_upgrades_e2e
branch
from
32ec000 to
2a258e6
Compare
|
/test pull-cluster-api-provider-openstack-e2e-full-test |
1 similar comment
|
/test pull-cluster-api-provider-openstack-e2e-full-test |
|
@sirpaleet: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Test ORC upgrades in e2e.
Which issue(s) this PR fixes:
Fixes #2568
Special notes for your reviewer:
Edits e2e tests.
TODOs:
/hold