-
Notifications
You must be signed in to change notification settings - Fork 277
🐛 #2617 Selecting fixed subnet when provided #2624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 #2617 Selecting fixed subnet when provided #2624
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Welcome @nonowheels63! |
Hi @nonowheels63. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
64dbe50
to
3000e36
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3000e36
to
1195a7a
Compare
Pease first propose a fix into main, and then we'll think about backporting. We can't fix a bug in a stable branch first. |
Hello, |
Closing. Let's take it into main and then we do the backport |
What this PR does / why we need it:
This PR enable the usage of a provided subnet when it is provided. At first the provided network wasn't used when the there where multiple subnet attached to the network, one random subnet was used (the first returned by the api).
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2617
Special notes for your reviewer:
This is the first PR i have ever made.
I have redo the work on the release-0.12 and the main branches if needed.
TODOs:
/hold