Skip to content

Hostname code path in servicediscovery controller does not work #3409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sbueringer opened this issue Mar 19, 2025 · 0 comments
Open

Hostname code path in servicediscovery controller does not work #3409

sbueringer opened this issue Mar 19, 2025 · 0 comments
Labels
area/supervisor Issues or PRs related to the supervisor mode

Comments

@sbueringer
Copy link
Member

sbueringer commented Mar 19, 2025 •
edited
Loading

Context: #3405 (comment)

This code path:

cluster-api-provider-vsphere/controllers/vmware/servicediscovery_controller.go

Line 394 in 393a169

endpointAddr.Hostname = targetHost
does not work, because IP is mandatory in EndpointAddress

Let's figure out what to do with it. The most straightforward change is to return an error if targetHost is not an IP

(Today we also return an error, but only after we tried to create an invalid Endpoints object)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/supervisor Issues or PRs related to the supervisor mode
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sbueringer