🌱 flavorgen: remove thumbprint from vSphereMachineTemplate for easier rotation #3375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
/hold For testing at team-cluster-api#62 |
k8s-ci-robot
added
the
do-not-merge/hold
|
/lgtm Makes sense |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: c1188544c92a5d921a523ca43e306563eb6898f3
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Different flake /retest |
k8s-ci-robot
removed
the
lgtm
chrischdi
force-pushed
the
pr-remove-thumbprint-vspheremachinetemplate
branch
2 times, most recently
from
09567e6 to
3180f26
Compare
chrischdi
force-pushed
the
pr-remove-thumbprint-vspheremachinetemplate
branch
from
3180f26 to
54b8240
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 384b571ea35a39c56c0214e4bf6ac2090626d616
|
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Rotating the thumbprint is hard when setting the thumbprint in vspheremachinetemplates. Thus changing the default flavors to only have it on vSphereCluster set.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):related to #3372
But not a solution for that issue.