Skip to content

Commit 13b8097

Browse files
authored
Merge pull request #4245 from MarcelMue/individual-service-accounts
⚠️ Use individual service accounts
2 parents a05b4ab + 780f050 commit 13b8097

25 files changed

+62
-12
lines changed

bootstrap/kubeadm/config/manager/manager.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ spec:
2525
image: controller:latest
2626
name: manager
2727
terminationGracePeriodSeconds: 10
28+
serviceAccountName: manager
2829
tolerations:
2930
- effect: NoSchedule
3031
key: node-role.kubernetes.io/master

bootstrap/kubeadm/config/rbac/auth_proxy_role_binding.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,5 @@ roleRef:
88
name: proxy-role
99
subjects:
1010
- kind: ServiceAccount
11-
name: default
11+
name: manager
1212
namespace: system

bootstrap/kubeadm/config/rbac/kustomization.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
resources:
22
- role.yaml
33
- role_binding.yaml
4+
- service_account.yaml
45
- leader_election_role.yaml
56
- leader_election_role_binding.yaml
67
- auth_proxy_service.yaml

bootstrap/kubeadm/config/rbac/leader_election_role_binding.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,5 @@ roleRef:
88
name: leader-election-role
99
subjects:
1010
- kind: ServiceAccount
11-
name: default
11+
name: manager
1212
namespace: system

bootstrap/kubeadm/config/rbac/role_binding.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,5 @@ roleRef:
88
name: manager-role
99
subjects:
1010
- kind: ServiceAccount
11-
name: default
11+
name: manager
1212
namespace: system
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
apiVersion: v1
2+
kind: ServiceAccount
3+
metadata:
4+
name: manager
5+
namespace: system

config/manager/manager.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ spec:
3838
path: /healthz
3939
port: healthz
4040
terminationGracePeriodSeconds: 10
41+
serviceAccountName: manager
4142
tolerations:
4243
- effect: NoSchedule
4344
key: node-role.kubernetes.io/master

config/rbac/auth_proxy_role_binding.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,5 @@ roleRef:
88
name: proxy-role
99
subjects:
1010
- kind: ServiceAccount
11-
name: default
11+
name: manager
1212
namespace: system

config/rbac/kustomization.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ kind: Kustomization
33
resources:
44
- role_binding.yaml
55
- role.yaml
6+
- service_account.yaml
67
- leader_election_role.yaml
78
- leader_election_role_binding.yaml
89
- aggregated_role.yaml

config/rbac/leader_election_role_binding.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,5 @@ roleRef:
88
name: leader-election-role
99
subjects:
1010
- kind: ServiceAccount
11-
name: default
11+
name: manager
1212
namespace: system

config/rbac/role_binding.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@ roleRef:
99
name: manager-role
1010
subjects:
1111
- kind: ServiceAccount
12-
name: default
12+
name: manager
1313
namespace: system

config/rbac/service_account.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
apiVersion: v1
2+
kind: ServiceAccount
3+
metadata:
4+
name: manager
5+
namespace: system

controlplane/kubeadm/config/manager/manager.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ spec:
2424
image: controller:latest
2525
name: manager
2626
terminationGracePeriodSeconds: 10
27+
serviceAccountName: manager
2728
tolerations:
2829
- effect: NoSchedule
2930
key: node-role.kubernetes.io/master

controlplane/kubeadm/config/rbac/auth_proxy_role_binding.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,5 @@ roleRef:
88
name: proxy-role
99
subjects:
1010
- kind: ServiceAccount
11-
name: default
11+
name: manager
1212
namespace: system

controlplane/kubeadm/config/rbac/kustomization.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
resources:
22
- role.yaml
33
- role_binding.yaml
4+
- service_account.yaml
45
- leader_election_role.yaml
56
- leader_election_role_binding.yaml
67
# Comment the following 3 lines if you want to disable

controlplane/kubeadm/config/rbac/leader_election_role_binding.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,5 @@ roleRef:
88
name: leader-election-role
99
subjects:
1010
- kind: ServiceAccount
11-
name: default
11+
name: manager
1212
namespace: system

controlplane/kubeadm/config/rbac/role_binding.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,5 @@ roleRef:
88
name: manager-role
99
subjects:
1010
- kind: ServiceAccount
11-
name: default
11+
name: manager
1212
namespace: system
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
apiVersion: v1
2+
kind: ServiceAccount
3+
metadata:
4+
name: manager
5+
namespace: system

docs/book/src/developer/providers/v1alpha3-to-v1alpha4.md

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -211,3 +211,25 @@ with `cert-manager.io/v1`
211211
return errors.Wrap(err, "failed setting up with a controller manager")
212212
}
213213
```
214+
215+
## Required changes to have individual service accounts for controllers.
216+
217+
1. Create a new service account such as:
218+
```yaml
219+
apiVersion: v1
220+
kind: ServiceAccount
221+
metadata:
222+
name: manager
223+
namespace: system
224+
```
225+
2. Change the `subject` of the managers `ClusterRoleBinding` to match:
226+
```yaml
227+
subjects:
228+
- kind: ServiceAccount
229+
name: manager
230+
namespace: system
231+
```
232+
3. Add the correct `serviceAccountName` to the manager deployment:
233+
```yaml
234+
serviceAccountName: manager
235+
```

test/infrastructure/docker/config/manager/manager.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ spec:
4040
securityContext:
4141
privileged: true
4242
terminationGracePeriodSeconds: 10
43+
serviceAccountName: manager
4344
tolerations:
4445
- effect: NoSchedule
4546
key: node-role.kubernetes.io/master

test/infrastructure/docker/config/rbac/auth_proxy_role_binding.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,5 @@ roleRef:
88
name: proxy-role
99
subjects:
1010
- kind: ServiceAccount
11-
name: default
11+
name: manager
1212
namespace: system

test/infrastructure/docker/config/rbac/kustomization.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ kind: Kustomization
33
resources:
44
- role.yaml
55
- role_binding.yaml
6+
- service_account.yaml
67
- leader_election_role.yaml
78
- leader_election_role_binding.yaml
89
# Comment the following 3 lines if you want to disable

test/infrastructure/docker/config/rbac/leader_election_role_binding.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,5 @@ roleRef:
88
name: leader-election-role
99
subjects:
1010
- kind: ServiceAccount
11-
name: default
11+
name: manager
1212
namespace: system

test/infrastructure/docker/config/rbac/role_binding.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,5 @@ roleRef:
88
name: manager-role
99
subjects:
1010
- kind: ServiceAccount
11-
name: default
11+
name: manager
1212
namespace: system
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
apiVersion: v1
2+
kind: ServiceAccount
3+
metadata:
4+
name: manager
5+
namespace: system

0 commit comments

Comments
 (0)