Fix review findings

Author: sbueringer

api/controlplane/kubeadm/v1beta2/kubeadm_control_plane_types.go

@@ -484,7 +484,7 @@ type KubeadmControlPlaneMachineTemplate struct {
 
 	// spec defines the spec for Machines
 	// in a KubeadmControlPlane object.
-	// +optional
+	// +required
 	Spec KubeadmControlPlaneMachineTemplateSpec `json:"spec,omitempty,omitzero"`
 }
 

api/controlplane/kubeadm/v1beta2/kubeadmcontrolplanetemplate_types.go

@@ -130,6 +130,7 @@ type KubeadmControlPlaneTemplateResourceSpec struct {
 // omits ObjectMeta and InfrastructureRef fields. These fields do not make sense on the KubeadmControlPlaneTemplate,
 // because they are calculated by the Cluster topology reconciler during reconciliation and thus cannot
 // be configured on the KubeadmControlPlaneTemplate.
+// +kubebuilder:validation:MinProperties=1
 type KubeadmControlPlaneTemplateMachineTemplate struct {
 	// metadata is the standard object's metadata.
 	// More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata
@@ -144,6 +145,7 @@ type KubeadmControlPlaneTemplateMachineTemplate struct {
 
 // KubeadmControlPlaneTemplateMachineTemplateSpec defines the spec for Machines
 // in a KubeadmControlPlane object.
+// +kubebuilder:validation:MinProperties=1
 type KubeadmControlPlaneTemplateMachineTemplateSpec struct {
 	// deletion contains configuration options for Machine deletion.
 	// +optional

controlplane/kubeadm/config/crd/bases/controlplane.cluster.x-k8s.io_kubeadmcontrolplanes.yaml

@@ -215,12 +215,8 @@ func (webhook *KubeadmControlPlane) ValidateUpdate(_ context.Context, oldObj, ne
 		// spec.machineTemplate
 		{spec, "machineTemplate", "metadata"},
 		{spec, "machineTemplate", "metadata", "*"},
-		{spec, "machineTemplate", "spec", "infrastructureRef", "apiGroup"},
-		{spec, "machineTemplate", "spec", "infrastructureRef", "name"},
-		{spec, "machineTemplate", "spec", "infrastructureRef", "kind"},
-		{spec, "machineTemplate", "spec", "deletion", "nodeDrainTimeoutSeconds"},
-		{spec, "machineTemplate", "spec", "deletion", "nodeVolumeDetachTimeoutSeconds"},
-		{spec, "machineTemplate", "spec", "deletion", "nodeDeletionTimeoutSeconds"},
+		{spec, "machineTemplate", "spec"},
+		{spec, "machineTemplate", "spec", "*"},
 		// spec
 		{spec, "replicas"},
 		{spec, "version"},