Remove deprecated Cluster.spec.topology.rolloutAfter field

Signed-off-by: Stefan Büringer buringerst@vmware.com

Author: sbueringer

api/core/v1beta1/conversion_test.go

@@ -76,6 +76,7 @@ func TestFuzzyConversion(t *testing.T) {
 func ClusterFuzzFuncs(_ runtimeserializer.CodecFactory) []interface{} {
 	return []interface{}{
 		hubClusterStatus,
+		spokeClusterTopology,
 		spokeClusterStatus,
 		spokeClusterVariable,
 	}
@@ -98,6 +99,13 @@ func hubClusterStatus(in *clusterv1.ClusterStatus, c fuzz.Continue) {
 	}
 }
 
+func spokeClusterTopology(in *Topology, c fuzz.Continue) {
+	c.FuzzNoCustom(in)
+
+	// RolloutAfter was unused and has been removed in v1beta2.
+	in.RolloutAfter = nil
+}
+
 func spokeClusterStatus(in *ClusterStatus, c fuzz.Continue) {
 	c.FuzzNoCustom(in)
 	// Drop empty structs with only omit empty fields.

api/core/v1beta1/zz_generated.conversion.go

@@ -548,14 +548,6 @@ type Topology struct {
 	// +kubebuilder:validation:MaxLength=256
 	Version string `json:"version"`
 
-	// rolloutAfter performs a rollout of the entire cluster one component at a time,
-	// control plane first and then machine deployments.
-	//
-	// Deprecated: This field has no function and is going to be removed in the next apiVersion.
-	//
-	// +optional
-	RolloutAfter *metav1.Time `json:"rolloutAfter,omitempty"`
-
 	// controlPlane describes the cluster control plane.
 	// +optional
 	ControlPlane ControlPlaneTopology `json:"controlPlane,omitempty"`

api/core/v1beta2/cluster_types.go

@@ -84,6 +84,7 @@ proposal because most of the changes described below are a consequence of the wo
 - See changes that apply to [all CRDs](#all-crds)
 - The `spec.topology.class` field has been renamed to `spec.topology.classRef.name`
 - The `spec.topology.classNamespace` field has been renamed to `spec.topology.classRef.namespace`
+- The `spec.topology.rolloutAfter` field has been removed (the corresponding functionality was never implemented)
 - The `definitionFrom` field (deprecated since CAPI v1.8) has been removed from
   - `spec.topology.variables`
   - `spec.topology.controlPlane.variables.overrides`

api/core/v1beta2/zz_generated.deepcopy.go

@@ -109,6 +109,7 @@ func ClusterFuzzFuncs(_ runtimeserializer.CodecFactory) []interface{} {
 	return []interface{}{
 		hubClusterVariable,
 		hubClusterStatus,
+		spokeClusterTopology,
 	}
 }
 
@@ -136,6 +137,13 @@ func hubClusterVariable(in *clusterv1.ClusterVariable, c fuzz.Continue) {
 	in.Value = apiextensionsv1.JSON{Raw: []byte("\"test-string\"")}
 }
 
+func spokeClusterTopology(in *Topology, c fuzz.Continue) {
+	c.FuzzNoCustom(in)
+
+	// RolloutAfter was unused and has been removed in v1beta2.
+	in.RolloutAfter = nil
+}
+
 func ClusterClassFuzzFuncs(_ runtimeserializer.CodecFactory) []interface{} {
 	return []interface{}{
 		hubJSONPatch,