Skip to content

Commit 47b33da

Browse files
committed
Fix review findings
1 parent e1ffc17 commit 47b33da

10 files changed

+20
-16
lines changed

api/v1beta1/cluster_types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -923,7 +923,7 @@ type ClusterNetwork struct {
923923
type NetworkRanges struct {
924924
// cidrBlocks is a list of CIDR blocks.
925925
// +kubebuilder:validation:MaxItems=100
926-
// +kubebuilder:validation:items:MaxLength=256
926+
// +kubebuilder:validation:items:MaxLength=43
927927
CIDRBlocks []string `json:"cidrBlocks"`
928928
}
929929

bootstrap/kubeadm/api/v1beta1/kubeadm_types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ type ClusterStatus struct {
233233
type APIEndpoint struct {
234234
// advertiseAddress sets the IP address for the API server to advertise.
235235
// +optional
236-
// +kubebuilder:validation:MaxLength=256
236+
// +kubebuilder:validation:MaxLength=39
237237
AdvertiseAddress string `json:"advertiseAddress,omitempty"`
238238

239239
// bindPort sets the secure port for the API Server to bind to.

bootstrap/kubeadm/config/crd/bases/bootstrap.cluster.x-k8s.io_kubeadmconfigs.yaml

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

bootstrap/kubeadm/config/crd/bases/bootstrap.cluster.x-k8s.io_kubeadmconfigtemplates.yaml

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/crd/bases/cluster.x-k8s.io_clusters.yaml

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/crd/bases/ipam.cluster.x-k8s.io_ipaddresses.yaml

Lines changed: 4 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

controlplane/kubeadm/config/crd/bases/controlplane.cluster.x-k8s.io_kubeadmcontrolplanes.yaml

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

controlplane/kubeadm/config/crd/bases/controlplane.cluster.x-k8s.io_kubeadmcontrolplanetemplates.yaml

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

exp/ipam/api/v1alpha1/ipaddress_types.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,15 @@ type IPAddressSpec struct {
3030
PoolRef corev1.TypedLocalObjectReference `json:"poolRef"`
3131

3232
// address is the IP address.
33+
// +kubebuilder:validation:MaxLength=39
3334
Address string `json:"address"`
3435

3536
// prefix is the prefix of the address.
3637
Prefix int `json:"prefix"`
3738

3839
// gateway is the network gateway of the network the address is from.
3940
// +optional
41+
// +kubebuilder:validation:MaxLength=39
4042
Gateway string `json:"gateway,omitempty"`
4143
}
4244

exp/ipam/api/v1beta1/ipaddress_types.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,15 @@ type IPAddressSpec struct {
3030
PoolRef corev1.TypedLocalObjectReference `json:"poolRef"`
3131

3232
// address is the IP address.
33-
// +kubebuilder:validation:MaxLength=256
33+
// +kubebuilder:validation:MaxLength=39
3434
Address string `json:"address"`
3535

3636
// prefix is the prefix of the address.
3737
Prefix int `json:"prefix"`
3838

3939
// gateway is the network gateway of the network the address is from.
4040
// +optional
41-
// +kubebuilder:validation:MaxLength=256
41+
// +kubebuilder:validation:MaxLength=39
4242
Gateway string `json:"gateway,omitempty"`
4343
}
4444

0 commit comments

Comments
 (0)