Skip to content

Commit baf9705

Browse files
fabriziopandinifabriziopandini
committed
Address feedback
1 parent 431b7bc commit baf9705

File tree

3 files changed

+67
-64
lines changed

3 files changed

+67
-64
lines changed

‎api/v1beta1/v1beta2_condition_consts.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -199,14 +199,14 @@ const (
199199
// infrastructure to be ready.
200200
WaitingForClusterInfrastructureV1Beta2Reason = "WaitingForClusterInfrastructure"
201201

202-
// WaitingControlPlaneInitializedV1Beta2Reason documents an infra Machine waiting
202+
// WaitingForControlPlaneInitializedV1Beta2Reason documents an infra Machine waiting
203203
// for the control plane to be initialized.
204-
WaitingControlPlaneInitializedV1Beta2Reason = "WaitingControlPlaneInitialized"
204+
WaitingForControlPlaneInitializedV1Beta2Reason = "WaitingForControlPlaneInitialized"
205205

206-
// WaitingForBootstrapData1Beta2DataReason documents an infra Machine waiting for the bootstrap
206+
// WaitingForBootstrapDataV1Beta2Reason documents an infra Machine waiting for the bootstrap
207207
// data to be ready before starting to create the Machine's infrastructure.
208-
WaitingForBootstrapData1Beta2DataReason = "WaitingForBootstrapData"
208+
WaitingForBootstrapDataV1Beta2Reason = "WaitingForBootstrapData"
209209

210-
// ProvisionedV1Beta2Reason documents a component being provisioned.
210+
// ProvisionedV1Beta2Reason documents an object or a piece of infrastructure being provisioned.
211211
ProvisionedV1Beta2Reason = "Provisioned"
212212
)

‎test/infrastructure/docker/api/v1beta1/devmachine_types.go

Lines changed: 42 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ const (
7070

7171
// DevMachine's Ready condition and corresponding reasons that will be used in v1Beta2 API version.
7272
const (
73-
// DevMachineReadyV1Beta2Condition is true if the DevMachine's VirtualMachineProvisioned, NodeProvisioned,
73+
// DevMachineReadyV1Beta2Condition is true if the DevMachine's VMProvisioned, NodeProvisioned,
7474
// EtcdProvisioned (if present) and APIServerProvisioned (if present) conditions are true.
7575
DevMachineReadyV1Beta2Condition = clusterv1.ReadyV1Beta2Condition
7676

@@ -87,95 +87,98 @@ const (
8787

8888
// DevMachine's v1Beta2 conditions that apply to the in memory backend.
8989

90-
// VirtualMachineProvisioned condition and corresponding reasons that will be used in v1Beta2 API version for a DevMachine's with in memory backend.
90+
// VirtualMachineProvisioned condition and corresponding reasons that will be used in v1Beta2 API version for a DevMachine's in memory backend.
9191
const (
92-
// DevMachineInMemoryVirtualMachineProvisionedV1Beta2Condition documents the status of the provisioning of a fake VirtualMachine for a DevMachine's with in memory backend.
93-
DevMachineInMemoryVirtualMachineProvisionedV1Beta2Condition string = "VirtualMachineProvisioned"
92+
// DevMachineInMemoryVMProvisionedV1Beta2Condition documents the status of the provisioning of a fake VM for a DevMachine's in memory backend.
93+
DevMachineInMemoryVMProvisionedV1Beta2Condition string = "VMProvisioned"
9494

95-
// DevMachineInMemoryVirtualMachineWaitingForClusterInfrastructureV1Beta2Reason documents a fake VirtualMachine for a DevMachine's with in memory backend waiting for the cluster
95+
// DevMachineInMemoryVMWaitingForClusterInfrastructureV1Beta2Reason documents a fake VM for a DevMachine's in memory backend waiting for the cluster
9696
// infrastructure to be ready.
97-
DevMachineInMemoryVirtualMachineWaitingForClusterInfrastructureV1Beta2Reason = clusterv1.WaitingForClusterInfrastructureV1Beta2Reason
97+
DevMachineInMemoryVMWaitingForClusterInfrastructureV1Beta2Reason = clusterv1.WaitingForClusterInfrastructureV1Beta2Reason
9898

99-
// DevMachineInMemoryVirtualMachineWaitingControlPlaneInitializedV1Beta2Reason documents a fake VirtualMachine for a DevMachine's with in memory backend waiting
99+
// DevMachineInMemoryVMWaitingForControlPlaneInitializedV1Beta2Reason documents a fake VM for a DevMachine's in memory backend waiting
100100
// for the control plane to be initialized.
101-
DevMachineInMemoryVirtualMachineWaitingControlPlaneInitializedV1Beta2Reason = clusterv1.WaitingControlPlaneInitializedV1Beta2Reason
101+
DevMachineInMemoryVMWaitingForControlPlaneInitializedV1Beta2Reason = clusterv1.WaitingForControlPlaneInitializedV1Beta2Reason
102102

103-
// DevMachineInMemoryVirtualMachineWaitingForBootstrapDataV1Beta2Reason documents a fake VirtualMachine for a DevMachine's with in memory backend waiting for the bootstrap
103+
// DevMachineInMemoryVMWaitingForBootstrapDataV1Beta2Reason documents a fake VM for a DevMachine's in memory backend waiting for the bootstrap
104104
// data to be ready.
105-
DevMachineInMemoryVirtualMachineWaitingForBootstrapDataV1Beta2Reason = clusterv1.WaitingForBootstrapData1Beta2DataReason
105+
DevMachineInMemoryVMWaitingForBootstrapDataV1Beta2Reason = clusterv1.WaitingForBootstrapDataV1Beta2Reason
106106

107-
// DevMachineInMemoryVirtualMachineWaitingForStartupTimeoutV1Beta2Reason documents the infrastructure for a fake VirtualMachine for a DevMachine's with in memory backend provisioning.
108-
DevMachineInMemoryVirtualMachineWaitingForStartupTimeoutV1Beta2Reason = "WaitingForStartupTimeout"
107+
// DevMachineInMemoryVMWaitingForStartupTimeoutV1Beta2Reason documents when the infrastructure for a fake VM for a DevMachine's in memory backend
108+
// is provisioning (it waits for a startup timeout).
109+
DevMachineInMemoryVMWaitingForStartupTimeoutV1Beta2Reason = "WaitingForStartupTimeout"
109110

110-
// DevMachineInMemoryVirtualMachineProvisionedV1Beta2Reason documents a fake VirtualMachine for a DevMachine's with in memory backend being provisioned.
111-
DevMachineInMemoryVirtualMachineProvisionedV1Beta2Reason = clusterv1.ProvisionedV1Beta2Reason
111+
// DevMachineInMemoryVMProvisionedV1Beta2Reason documents when a fake VM for a DevMachine's in memory backend is fully provisioned.
112+
DevMachineInMemoryVMProvisionedV1Beta2Reason = clusterv1.ProvisionedV1Beta2Reason
112113

113-
// DevMachineInMemoryVirtualMachineInternalErrorV1Beta2Reason surfaces unexpected error when reconciling a fake VirtualMachine for a DevMachine's with in memory backend.
114-
DevMachineInMemoryVirtualMachineInternalErrorV1Beta2Reason = clusterv1.InternalErrorV1Beta2Reason
114+
// DevMachineInMemoryVMInternalErrorV1Beta2Reason surfaces unexpected error when reconciling a fake VM for a DevMachine's in memory backend.
115+
DevMachineInMemoryVMInternalErrorV1Beta2Reason = clusterv1.InternalErrorV1Beta2Reason
115116
)
116117

117-
// NodeProvisioned condition and corresponding reasons that will be used in v1Beta2 API version for a DevMachine's with in memory backend.
118+
// NodeProvisioned condition and corresponding reasons that will be used in v1Beta2 API version for a DevMachine's in memory backend.
118119
const (
119-
// DevMachineInMemoryNodeProvisionedV1Beta2Condition documents the status of the provisioning of the node hosted on the InMemoryMachine.
120+
// DevMachineInMemoryNodeProvisionedV1Beta2Condition documents the status of the provisioning of the node hosted on the DevMachine's in memory backend.
120121
DevMachineInMemoryNodeProvisionedV1Beta2Condition string = "NodeProvisioned"
121122

122-
// DevMachineInMemoryNodeWaitingForVirtualMachineProvisionedV1Beta2Reason documents a fake Node for a DevMachine's with in memory backend waiting for the VirtualMachine
123+
// DevMachineInMemoryNodeWaitingForVMProvisionedV1Beta2Reason documents a fake Node for a DevMachine's in memory backend waiting for the VM
123124
// to be provisioned.
124-
DevMachineInMemoryNodeWaitingForVirtualMachineProvisionedV1Beta2Reason = "WaitingForVirtualMachineProvisioned"
125+
DevMachineInMemoryNodeWaitingForVMProvisionedV1Beta2Reason = "WaitingForVMProvisioned"
125126

126-
// DevMachineInMemoryNodeWaitingForStartupTimeoutV1Beta2Reason documents the fake Node for a DevMachine's with in memory backend provisioning.
127+
// DevMachineInMemoryNodeWaitingForStartupTimeoutV1Beta2Reason documents when the fake Node for a DevMachine's in memory backend
128+
// is provisioning (it waits for a startup timeout).
127129
DevMachineInMemoryNodeWaitingForStartupTimeoutV1Beta2Reason = "WaitingForStartupTimeout"
128130

129-
// DevMachineInMemoryNodeProvisionedV1Beta2DataReason documents a fake Node for a DevMachine's with in memory backend being provisioned.
131+
// DevMachineInMemoryNodeProvisionedV1Beta2Reason documents when a fake Node for a DevMachine's in memory backend is fully provisioned.
130132
DevMachineInMemoryNodeProvisionedV1Beta2Reason = clusterv1.ProvisionedV1Beta2Reason
131133

132-
// DevMachineInMemoryNodeInternalErrorV1Beta2Reason surfaces unexpected error when reconciling a fake Node for a DevMachine's with in memory backend.
134+
// DevMachineInMemoryNodeInternalErrorV1Beta2Reason surfaces unexpected error when reconciling a fake Node for a DevMachine's in memory backend.
133135
DevMachineInMemoryNodeInternalErrorV1Beta2Reason = clusterv1.InternalErrorV1Beta2Reason
134136
)
135137

136-
// EtcdProvisioned condition and corresponding reasons that will be used in v1Beta2 API version for a DevMachine's with in memory backend.
138+
// EtcdProvisioned condition and corresponding reasons that will be used in v1Beta2 API version for a DevMachine's in memory backend.
137139
const (
138-
// DevMachineInMemoryEtcdProvisionedV1Beta2Condition documents the status of the provisioning VM implementing the InMemoryMachine.
140+
// DevMachineInMemoryEtcdProvisionedV1Beta2Condition documents the status of the provisioning VM implementing the DevMachine's in memory backend.
139141
DevMachineInMemoryEtcdProvisionedV1Beta2Condition string = "EtcdProvisioned"
140142

141-
// DevMachineInMemoryEtcdWaitingForVirtualMachineProvisionedV1Beta2Reason documents a fake Etcd for a DevMachine's with in memory backend waiting for the VirtualMachine
143+
// DevMachineInMemoryEtcdWaitingForVMProvisionedV1Beta2Reason documents a fake Etcd for a DevMachine's in memory backend waiting for the VM
142144
// to be provisioned.
143-
DevMachineInMemoryEtcdWaitingForVirtualMachineProvisionedV1Beta2Reason = "WaitingForVirtualMachineProvisioned"
145+
DevMachineInMemoryEtcdWaitingForVMProvisionedV1Beta2Reason = "WaitingForVMProvisioned"
144146

145-
// DevMachineInMemoryEtcdWaitingForNodeProvisionedV1Beta2Reason documents a fake Etcd for a DevMachine's with in memory backend waiting for the Node
147+
// DevMachineInMemoryEtcdWaitingForNodeProvisionedV1Beta2Reason documents a fake Etcd for a DevMachine's in memory backend waiting for the Node
146148
// to be provisioned.
147149
DevMachineInMemoryEtcdWaitingForNodeProvisionedV1Beta2Reason = "WaitingForNodeProvisioned"
148150

149-
// DevMachineInMemoryEtcdWaitingForStartupTimeoutV1Beta2Reason documents the fake Etcd for a DevMachine's with in memory backend provisioning.
151+
// DevMachineInMemoryEtcdWaitingForStartupTimeoutV1Beta2Reason documents when the fake Etcd for a DevMachine's in memory backend
152+
// is provisioning (it waits for a startup timeout).
150153
DevMachineInMemoryEtcdWaitingForStartupTimeoutV1Beta2Reason = "WaitingForStartupTimeout"
151154

152-
// DevMachineInMemoryEtcdProvisionedV1Beta2DataReason documents a fake Etcd for a DevMachine's with in memory backend being provisioned.
155+
// DevMachineInMemoryEtcdProvisionedV1Beta2Reason documents when a fake Etcd for a DevMachine's in memory backend is fully provisioned.
153156
DevMachineInMemoryEtcdProvisionedV1Beta2Reason = clusterv1.ProvisionedV1Beta2Reason
154157

155-
// DevMachineInMemoryEtcdInternalErrorV1Beta2Reason surfaces unexpected error when reconciling a fake Etcd for a DevMachine's with in memory backend.
158+
// DevMachineInMemoryEtcdInternalErrorV1Beta2Reason surfaces unexpected error when reconciling a fake Etcd for a DevMachine's in memory backend.
156159
DevMachineInMemoryEtcdInternalErrorV1Beta2Reason = clusterv1.InternalErrorV1Beta2Reason
157160
)
158161

159-
// APIServerProvisioned condition and corresponding reasons that will be used in v1Beta2 API version for a DevMachine's with in memory backend.
162+
// APIServerProvisioned condition and corresponding reasons that will be used in v1Beta2 API version for a DevMachine's in memory backend.
160163
const (
161-
// DevMachineInMemoryAPIServerProvisionedV1Beta2Condition documents the status of the provisioning of the APIServer instance hosted on the InMemoryMachine.
164+
// DevMachineInMemoryAPIServerProvisionedV1Beta2Condition documents the status of the provisioning of the APIServer instance hosted on the DevMachine's in memory backend.
162165
DevMachineInMemoryAPIServerProvisionedV1Beta2Condition string = "APIServerProvisioned"
163166

164-
// DevMachineInMemoryAPIServerWaitingForVirtualMachineProvisionedV1Beta2Reason documents a fake APIServer for a DevMachine's with in memory backend waiting for the VirtualMachine
167+
// DevMachineInMemoryAPIServerWaitingForVMProvisionedV1Beta2Reason documents a fake APIServer for a DevMachine's in memory backend waiting for the VM
165168
// to be provisioned.
166-
DevMachineInMemoryAPIServerWaitingForVirtualMachineProvisionedV1Beta2Reason = "WaitingForVirtualMachineProvisioned"
169+
DevMachineInMemoryAPIServerWaitingForVMProvisionedV1Beta2Reason = "WaitingForVMProvisioned"
167170

168-
// DevMachineInMemoryAPIServerWaitingForNodeProvisionedV1Beta2Reason documents a fake APIServer for a DevMachine's with in memory backend waiting for the Node
171+
// DevMachineInMemoryAPIServerWaitingForNodeProvisionedV1Beta2Reason documents a fake APIServer for a DevMachine's in memory backend waiting for the Node
169172
// to be provisioned.
170173
DevMachineInMemoryAPIServerWaitingForNodeProvisionedV1Beta2Reason = "WaitingForNodeProvisioned"
171174

172-
// DevMachineInMemoryAPIServerWaitingForStartupTimeoutV1Beta2Reason documents the infrastructure for a fake APIServer for a DevMachine's with in memory backend provisioning.
175+
// DevMachineInMemoryAPIServerWaitingForStartupTimeoutV1Beta2Reason documents the infrastructure for a fake APIServer for a DevMachine's in memory backend provisioning.
173176
DevMachineInMemoryAPIServerWaitingForStartupTimeoutV1Beta2Reason = "WaitingForStartupTimeout"
174177

175-
// DevMachineInMemoryAPIServerProvisionedV1Beta2DataReason documents a fake APIServer for a DevMachine's with in memory backend being provisioned.
178+
// DevMachineInMemoryAPIServerProvisionedV1Beta2Reason documents a fake APIServer for a DevMachine's in memory backend being provisioned.
176179
DevMachineInMemoryAPIServerProvisionedV1Beta2Reason = clusterv1.ProvisionedV1Beta2Reason
177180

178-
// DevMachineInMemoryAPIServerInternalErrorV1Beta2Reason surfaces unexpected error when reconciling a fake APIServer for a DevMachine's with in memory backend.
181+
// DevMachineInMemoryAPIServerInternalErrorV1Beta2Reason surfaces unexpected error when reconciling a fake APIServer for a DevMachine's in memory backend.
179182
DevMachineInMemoryAPIServerInternalErrorV1Beta2Reason = clusterv1.InternalErrorV1Beta2Reason
180183
)
181184

0 commit comments

Comments
 (0)