Skip to content

Commit e95ff05

Browse files
authored
Merge pull request #11911 from sivchari/enable-nobools
🌱 Enable nobools linter
2 parents 26d562e + 0d317ad commit e95ff05

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

.golangci-kal.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ linters-settings:
2121
- "statussubresource" # All root objects that have a `status` field should have a status subresource.
2222
- "nofloats" # Ensure floats are not used.
2323
- "maxlength" # Ensure all strings and arrays have maximum lengths/maximum items.
24+
- "nobools" # Bools do not evolve over time, should use enums instead.
2425

2526
# Per discussion in July 2024, we are keeping phase fields for now.
2627
# See https://github.com/kubernetes-sigs/cluster-api/pull/10897#discussion_r1685929508
@@ -30,7 +31,6 @@ linters-settings:
3031
# Linters below this line are disabled, pending conversation on how and when to enable them.
3132
# - "commentstart" # Ensure comments start with the serialized version of the field name.
3233
# - "jsontags" # Ensure every field has a json tag.
33-
# - "nobools" # Bools do not evolve over time, should use enums instead.
3434
# - "optionalorrequired" # Every field should be marked as `+optional` or `+required`.
3535
# - "requiredfields" # Required fields should not be pointers, and should not have `omitempty`.
3636
disable:
@@ -78,3 +78,7 @@ issues:
7878
text: "maxlength"
7979
linters:
8080
- kal
81+
- path: "api/v1alpha1/*|api/v1beta1/*"
82+
text: "nobools"
83+
linters:
84+
- kal

0 commit comments

Comments
 (0)