Skip to content

Commit eec55ae

Browse files
committed
util/deprecated: use clusterv1.Cluster
1 parent 2999c97 commit eec55ae

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

util/deprecated/v1beta1/paused/paused.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ import (
2929
"sigs.k8s.io/controller-runtime/pkg/client/apiutil"
3030

3131
clusterv1beta1 "sigs.k8s.io/cluster-api/api/v1beta1"
32+
clusterv1 "sigs.k8s.io/cluster-api/api/v1beta2"
3233
"sigs.k8s.io/cluster-api/util/annotations"
3334
v1beta2conditions "sigs.k8s.io/cluster-api/util/deprecated/v1beta1/conditions/v1beta2"
3435
"sigs.k8s.io/cluster-api/util/deprecated/v1beta1/patch"
@@ -41,7 +42,7 @@ type ConditionSetter interface {
4142
}
4243

4344
// EnsurePausedCondition sets the paused condition on the object and returns if it should be considered as paused.
44-
func EnsurePausedCondition(ctx context.Context, c client.Client, cluster *clusterv1beta1.Cluster, obj ConditionSetter) (isPaused bool, requeue bool, err error) {
45+
func EnsurePausedCondition(ctx context.Context, c client.Client, cluster *clusterv1.Cluster, obj ConditionSetter) (isPaused bool, requeue bool, err error) {
4546
oldCondition := v1beta2conditions.Get(obj, clusterv1beta1.PausedV1Beta2Condition)
4647
newCondition := pausedCondition(c.Scheme(), cluster, obj, clusterv1beta1.PausedV1Beta2Condition)
4748

@@ -90,7 +91,7 @@ func EnsurePausedCondition(ctx context.Context, c client.Client, cluster *cluste
9091
}
9192

9293
// pausedCondition sets the paused condition on the object and returns if it should be considered as paused.
93-
func pausedCondition(scheme *runtime.Scheme, cluster *clusterv1beta1.Cluster, obj ConditionSetter, targetConditionType string) metav1.Condition {
94+
func pausedCondition(scheme *runtime.Scheme, cluster *clusterv1.Cluster, obj ConditionSetter, targetConditionType string) metav1.Condition {
9495
if (cluster != nil && cluster.Spec.Paused) || annotations.HasPaused(obj) {
9596
var messages []string
9697
if cluster != nil && cluster.Spec.Paused {

util/deprecated/v1beta1/paused/paused_test.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ import (
2828
"sigs.k8s.io/controller-runtime/pkg/client/fake"
2929

3030
clusterv1beta1 "sigs.k8s.io/cluster-api/api/v1beta1"
31+
clusterv1 "sigs.k8s.io/cluster-api/api/v1beta2"
3132
v1beta2conditions "sigs.k8s.io/cluster-api/util/deprecated/v1beta1/conditions/v1beta2"
3233
"sigs.k8s.io/cluster-api/util/deprecated/v1beta1/test/builder"
3334
)
@@ -37,10 +38,10 @@ func TestEnsurePausedCondition(t *testing.T) {
3738

3839
scheme := runtime.NewScheme()
3940
g.Expect(builder.AddTransitionV1Beta2ToScheme(scheme)).To(Succeed())
40-
g.Expect(clusterv1beta1.AddToScheme(scheme)).To(Succeed())
41+
g.Expect(clusterv1.AddToScheme(scheme)).To(Succeed())
4142

4243
// Cluster Case 1: unpaused
43-
normalCluster := &clusterv1beta1.Cluster{
44+
normalCluster := &clusterv1.Cluster{
4445
ObjectMeta: metav1.ObjectMeta{
4546
Name: "some-cluster",
4647
Namespace: "default",
@@ -64,7 +65,7 @@ func TestEnsurePausedCondition(t *testing.T) {
6465

6566
tests := []struct {
6667
name string
67-
cluster *clusterv1beta1.Cluster
68+
cluster *clusterv1.Cluster
6869
object ConditionSetter
6970
wantIsPaused bool
7071
wantRequeueAfterGenerationChange bool
@@ -103,7 +104,7 @@ func TestEnsurePausedCondition(t *testing.T) {
103104
g := NewWithT(t)
104105
ctx := context.Background()
105106

106-
c := fake.NewClientBuilder().WithScheme(scheme).WithStatusSubresource(&clusterv1beta1.Cluster{}, &builder.Phase1Obj{}).
107+
c := fake.NewClientBuilder().WithScheme(scheme).WithStatusSubresource(&clusterv1.Cluster{}, &builder.Phase1Obj{}).
107108
WithObjects(tt.object, tt.cluster).Build()
108109

109110
g.Expect(c.Get(ctx, client.ObjectKeyFromObject(tt.object), tt.object)).To(Succeed())

0 commit comments

Comments
 (0)