Skip to content

clusterctl: cert-manager doesn't update even if image override has been changed #12119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmvolod opened this issue Apr 23, 2025 · 3 comments
Assignees
Labels
area/clusterctl Issues or PRs related to clusterctl kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@dmvolod
Copy link
Member

dmvolod commented Apr 23, 2025

What steps did you take and what happened?

We are using repository image override option in our clusterctl.yaml file as:

images:
  all:
    repository: myorg.io/local-repo

At some point, we may need to change the repository and update all components of the cluster API. We update the clusterctl.yaml file and run the clusterctl upgrade apply command. All providers are updated correctly, but the cert-manager is not updated.

What did you expect to happen?

We expect all components (providers + cert-manager) including deployments image paths to be updated as they are managed from the clustersctl.yaml file directly.

Cluster API version

v1.8.5

Kubernetes version

No response

Anything else you would like to add?

From the point of view of the cert-manager update code, I see that if its version does not change, then the only criterion for updating will be a different number of installed and installing objects, which is not true. In reality, the number of objects are the same, but the images in the Deployments are different. This should be validated in advance, as images can be managed from the clusterctl.yaml file.

Will fix this issue, if it suitable

Label(s) to be applied

/kind bug
/area clusterctl

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. area/clusterctl Issues or PRs related to clusterctl needs-priority Indicates an issue lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 23, 2025
@chrischdi
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 9, 2025
@dmvolod
Copy link
Member Author

dmvolod commented May 12, 2025

/assign

@chrischdi
Copy link
Member

/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates an issue lacks a `priority/foo` label and requires one. labels May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clusterctl Issues or PRs related to clusterctl kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants