Skip to content

Provide ApplyConfigurations #12154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cwrau opened this issue May 6, 2025 · 2 comments
Open

Provide ApplyConfigurations #12154

cwrau opened this issue May 6, 2025 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@cwrau
Copy link
Contributor

cwrau commented May 6, 2025

What would you like to be added (User Story)?

As an operator I want to provision Clusters via Go using SSA because SSA makes it easier to work together on the same resource, e.g. Clusters which get their controlPlaneEndpoint, controlPlaneRef, infrastructureRef, ... set by another operator (cluster-api).

Detailed Description

As an operator I want to provision Clusters via Go using SSA. As far as I can tell SSA is implemented via ApplyConfigurations.

Therefore, I'd like to have these provided by cluster-api.

Anything else you would like to add?

I've tested adding // +genclient to https://github.com/kubernetes-sigs/cluster-api/blob/main/api/v1beta2/cluster_types.go?plain=1#L1169 which allowed me to generate these configurations from my application, but I'm not sure how to hook into your CI and where to generate the code to, ...

Label(s) to be applied

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates an issue lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 6, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If CAPI contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chrischdi
Copy link
Member

Before thinking about if we should generate and provide generated ApplyConfigurations, there are bugs which need to be resolved in controller-tools:

Note: The new applyconfiguration generator has the following known issues: kubernetes-sigs/controller-tools#1193 kubernetes-sigs/controller-tools#1194

source: https://github.com/kubernetes-sigs/controller-tools/releases/tag/v0.18.0

Let's reconsider after these bugs got fixed.

/priority backlog

(on purpose no triage accepted for now)

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates an issue lacks a `priority/foo` label and requires one. labels May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

3 participants