Consider merging ClusterClass changes and rollout e2e tests

[sbueringer]

Follow-up:

Not for now, but I think that if we expand this a little bit this part we can merge ClusterClassChangesSpec into this test

I was thinking about the overlap between those tests as well.

Currently I went with separate tests as the ClusterClass changes test can be used with arbitrary control plane and bootstrap providers while the rollout test specifically tests behavior of KCP (in-place propagation).

As in-place propagation is not part of our contract and not even all control plane providers have a machineTemplate I thought it to be cleaner / easier to understand if we have a clean separation. So that one test is testing basic ClusterClass "actions" while the other one is testing the entire in-place propagation specifically for KCP etc.

I think there is probably a way to add some flags etc so we can have both in one test. I'm just not sure if this makes the test to complicated. Right now both tests seem nicely focused on their task, although there is definitely overlap.

xref: #8171 (comment)

/kind cleanup
/area testing

[fabriziopandini]

/triage accepted
/help

Not a high priority, but let's consider making the KCP/providers part pluggable so we can merge the two tests and keep our test machinery as lean as possible.

[k8s-ci-robot]

@fabriziopandini:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/triage accepted
/help

Not a high priority, but let's consider making the KCP/providers part pluggable so we can merge the two tests and keep our test machinery as lean as possible.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-triage-robot]

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

• Confirm that this issue is still relevant with /triage accepted (org members only)
• Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

[fabriziopandini]

/priority backlog

[fabriziopandini]

/close

We will eventually do this by opportunity if we have to touch those tests again