Skip to content

🌱 Add v1beta2 conditions to DevMachines with InMemory backend #11901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2025
Merged

🌱 Add v1beta2 conditions to DevMachines with InMemory backend #11901

merged 1 commit into from
Mar 3, 2025

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:

rif #11474

@fabriziopandini fabriziopandini added the area/provider/infrastructure-docker Issues or PRs related to the docker infrastructure provider label Feb 25, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 25, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 25, 2025
@fabriziopandini fabriziopandini mentioned this pull request Feb 25, 2025
Closed
10 tasks
@sbueringer
Copy link
Member

/retest

Probably caused by this PR (I didn't take a closer look)

@fabriziopandini fabriziopandini added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 25, 2025
sbueringer
sbueringer reviewed Feb 25, 2025
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just constant naming & godoc nits

chrischdi
chrischdi reviewed Feb 27, 2025
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, maybe optional (in addition to stefan's :-) )

@fabriziopandini fabriziopandini force-pushed the add-v1beta2-conditions-to-DevMachine-InMemory branch from 9afcb01 to baf9705 Compare February 27, 2025 14:48
sbueringer
sbueringer reviewed Feb 28, 2025
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last round of nits. Thx for the patience, I know this level of nitpickery is maybe a bit too much for a Dev provider :)

@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1057272fbaca35ad514e9ca68feb851e71c93dd1

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2025
@fabriziopandini fabriziopandini force-pushed the add-v1beta2-conditions-to-DevMachine-InMemory branch from 0329e7b to c38dec8 Compare March 3, 2025 13:08
@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main c38dec8 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit c9261b0 into kubernetes-sigs:main Mar 3, 2025
15 of 16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Mar 3, 2025
cprivitere pushed a commit to cprivitere/cluster-api that referenced this pull request Mar 18, 2025
@fabriziopandini @cprivitere
Aad v1beta2 conditions to DevMachines with InMemory backend (kubernet…
3733ddf 
…es-sigs#11901)
@fabriziopandini fabriziopandini deleted the add-v1beta2-conditions-to-DevMachine-InMemory branch April 12, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@sbueringer sbueringer sbueringer left review comments

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/infrastructure-docker Issues or PRs related to the docker infrastructure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
4 participants
@fabriziopandini @sbueringer @k8s-ci-robot @chrischdi