Skip to content

✨ Bump controller-tools v0.17.3, conversion-gen v0.33.0 #12129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 15, 2025
Merged

✨ Bump controller-tools v0.17.3, conversion-gen v0.33.0 #12129

merged 2 commits into from
May 15, 2025

Conversation

sivchari
Copy link
Member

@sivchari sivchari commented Apr 25, 2025 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Part of #11642

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 25, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 25, 2025
@sivchari
Copy link
Member Author

sivchari commented Apr 25, 2025 •
edited
Loading

/hold Wait controller-runtime latest release
kubernetes-sigs/controller-runtime#3123

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2025
@sivchari
Copy link
Member Author

go: k8s.io/code-generator/cmd/conversion-gen@v0.33.0: k8s.io/code-generator@v0.33.0 requires go >= 1.24.0 (running go 1.23.8; GOTOOLCHAIN=go1.23.8)

#12128 must be merged at first since the latest tool uses Go1.24

@sivchari sivchari changed the title ✨ [WIP] Bump controller-tools v0.17.3, conversion-gen v0.33.0 ✨ Bump controller-tools v0.17.3, conversion-gen v0.33.0 May 8, 2025
@sivchari
Copy link
Member Author

sivchari commented May 8, 2025

/area dependency

@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes and removed do-not-merge/needs-area PR is missing an area label labels May 8, 2025
@sbueringer
Copy link
Member

Diff looks good
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5a8161207fd4039236472b0695de6ac3e65de5b6

@sbueringer sbueringer mentioned this pull request May 14, 2025
Closed
15 tasks
@sbueringer
Copy link
Member

sbueringer commented May 14, 2025 •
edited
Loading

@sivchari Please check if you can directly bump to controller-tools v0.18.0 once #12128 is merged

I would try to get this merged before the CR bump if technically possible (without any hacks though :D)

@sbueringer sbueringer mentioned this pull request May 15, 2025
Closed
1 task
@sbueringer
Copy link
Member

Go 1.24 PR merged now. Should unblock this PR

sbueringer
sbueringer reviewed May 15, 2025
View reviewed changes
hack/tools/go.mod
@@ -27,7 +27,7 @@ require (
sigs.k8s.io/cluster-api v0.0.0-00010101000000-000000000000
sigs.k8s.io/cluster-api/test v0.0.0-00010101000000-000000000000
sigs.k8s.io/controller-runtime v0.20.4
sigs.k8s.io/controller-tools v0.17.0
sigs.k8s.io/controller-tools v0.17.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this on 0.17.3 in this PR and not bump to 0.18 like I suggested

Bumping this to v0.18 would require CR v0.21, but just bumping the controller-gen binary is fine

I'll bump this to 0.18 as part of my CR PR

sivchari added 2 commits May 15, 2025 14:31
@sivchari
Bump controller-tools v0.17.3, conversion-gen v0.33.0
a6eceb1 
Signed-off-by: sivchari <shibuuuu5@gmail.com>
@sivchari
Regenerate crd
09d97fa 
Signed-off-by: sivchari <shibuuuu5@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2025
@k8s-ci-robot k8s-ci-robot requested a review from sbueringer May 15, 2025 05:31
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 63ab0669acc6594c690118144eecbe86bb1dca3c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2025
@sbueringer
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7852761 into kubernetes-sigs:main May 15, 2025
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre Awaiting requested review from enxebre

@g-gaston g-gaston Awaiting requested review from g-gaston

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.
3 participants
@sivchari @sbueringer @k8s-ci-robot