[WIP] ✨ Use randfill for Fuzzing #12185
Conversation
Signed-off-by: sivchari <shibuuuu5@gmail.com>
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This PR is currently missing an area label, which is used to identify the modified component when generating release notes. Area labels can be added by org members by writing Please see the labels list for possible areas. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
do-not-merge/needs-area
|
@sivchari: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
do-not-merge/work-in-progress
| @@ -42,18 +42,20 @@ require ( | |||
| google.golang.org/grpc v1.67.3 | |||
| k8s.io/api v0.32.3 | |||
| k8s.io/apiextensions-apiserver v0.32.3 | |||
| k8s.io/apimachinery v0.32.3 | |||
| k8s.io/apimachinery v0.33.0 | |||
There was a problem hiding this comment.
Do we have an in-flight PR to update all the deps to 0.33? We probably want to do this in tandem.
Perhaps we hold this until the 1.33 updates have gone through
There was a problem hiding this comment.
Yup. We'll do the Go 1.24 and CR bump before. CR will include v0.33.0
There was a problem hiding this comment.
@sivchari Looks like I need to move to randfill as part of the CR bump already. They changed the return parameter of apitesting.fuzzer.FuzzerFor to *randfill.Filler. I'll see how far I can get with making only minimal changes
There was a problem hiding this comment.
Looks like I have to do everything to be able to bump CR
There was a problem hiding this comment.
@sbueringer
Sorry for the late reply.
Yeah, I thought this PR will be closed since the upgrading CR includes this patch.
#12191 completely include my changes on this PR. I close this, then would review #12191 👍
There was a problem hiding this comment.
Thank you very much!
No worries, I don't expect instant replies :)
| k8s.io/utils v0.0.0-20241104100929-3ea5e8cea738 | ||
| sigs.k8s.io/controller-runtime v0.20.4 | ||
| sigs.k8s.io/yaml v1.4.0 | ||
| ) | ||
|
|
||
| require sigs.k8s.io/randfill v1.0.0 |
There was a problem hiding this comment.
Why does this end up as a separate require?
There was a problem hiding this comment.
Fixed in #12191
I think this only ended up here because either an IDE or go somehow adds it per default this way (also happened to me). But yes we want this in the block above.
|
/close |
|
@sivchari: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #12095