🌱 Recover v1.10 util packages for conditions, patch and paused to util/deprecated/v1beta1 for provider migrations #12224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/util
k8s-ci-robot
added
the
size/XXL
chrischdi
commented
May 16, 2025
chrischdi
force-pushed
the
readd-old-conditions-and-patch-utils-for-migration
branch
from
bd68d15 to
295904c
Compare
fabriziopandini
added
the
tide/merge-method-squash
There was a problem hiding this comment.
We are always going miles to help CAPI users!
Thanks!
cc @sbueringer
| SetupReconcilers func(ctx context.Context, mgr ctrl.Manager) | ||
| SetupEnv func(e *Environment) | ||
| MinK8sVersion string | ||
| AdditionalSchemeBuilder runtime.SchemeBuilder |
There was a problem hiding this comment.
nit: should this be
Suggested change
| AdditionalSchemeBuilder runtime.SchemeBuilder | |
| AdditionalSchemeBuilders []runtime.SchemeBuilder |
(not blocking it is an internal util, we can always iterate in future)
There was a problem hiding this comment.
runtime.Schemebuilder is already an []func(*Scheme) error which is a collection of AddScheme funcs :-)
sbueringer
reviewed
May 16, 2025
sbueringer
reviewed
May 19, 2025
|
/lgtm /assign @fabriziopandini |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: c58d431e44579e7f86fd230915cecead258b6d2d
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
sbueringer
pushed a commit
to sbueringer/cluster-api
that referenced
this pull request
May 19, 2025
…l/deprecated/v1beta1 for provider migrations (kubernetes-sigs#12224) * Recover v1.10 util/conditions and util/patch to util/deprecated/v1beta1 for providers * util/deprecated: add package deprecation information to packages * readd util/deprecated/v1beta1/paused * util/deprecated: use deprecated packages for paused * util/deprecated: use clusterv1.Cluster * fix deprecated tests * util/deprecated/v1beta1/test add ObservedGeneration to Phase1Obj and generate CRD * util/test allow to pass in custom crd paths and scheme builders * envtest: adjust godoc for global scheme * envtest: review fixes * deprecated: rename func parameters * fixup renaming * fixup linter changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Re-adds the packages:
sigs.k8s.io/cluster-api/util/patchassigs.k8s.io/cluster-api/util/deprecated/v1beta1/patchsigs.k8s.io/cluster-api/util/conditionsassigs.k8s.io/cluster-api/util/deprecated/v1beta1/conditionssigs.k8s.io/cluster-api/util/pausedassigs.k8s.io/cluster-api/util/deprecated/v1beta1/pausedFrom version v1.10.
This allows providers a smoother and more step-by-step migration to v1beta2.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
/area util