⚠️ Restructure classRef field in Cluster.spec.topology #12235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
72 tasks
sbueringer
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
sbueringer
commented
May 16, 2025
sbueringer
force-pushed
the
pr-restructure-class-ref
branch
from
47e570d to
6d04af6
Compare
sbueringer
commented
May 16, 2025
sbueringer
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/test pull-cluster-api-e2e-main /hold |
k8s-ci-robot
added
the
do-not-merge/hold
sbueringer
force-pushed
the
pr-restructure-class-ref
branch
2 times, most recently
from
73d1d65 to
c5b035e
Compare
Signed-off-by: Stefan Büringer buringerst@vmware.com
sbueringer
force-pushed
the
pr-restructure-class-ref
branch
from
c5b035e to
0f149c2
Compare
|
/test pull-cluster-api-e2e-main |
|
changes lgtm, I will take another look after API review + changes for build in variables |
JoelSpeed
reviewed
May 19, 2025
sbueringer
added
the
tide/merge-method-squash
k8s-ci-robot
added
size/XL
|
@fabriziopandini @JoelSpeed PTAL :) |
|
/test pull-cluster-api-e2e-main |
sbueringer
force-pushed
the
pr-restructure-class-ref
branch
from
7c3c8d1 to
41f0232
Compare
|
/test pull-cluster-api-e2e-main |
|
/test pull-cluster-api-e2e-main |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: c931a100303e4db3e3fc117df009da41eeccb99e
|
docs/book/src/tasks/experimental-features/cluster-class/write-clusterclass.md
Show resolved
Hide resolved
|
I'll open a cherry-pick PR. Can one of you approve the PR please? :) |
14 tasks
|
/approve Thanks @sbueringer |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Thx! Cherry-pick PR #12252 Would be good to merge ASAP so we can include it in the patch release today |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #11500
Part of #10852