Skip to content

📖 Improve Go bump instructions #12246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

📖 Improve Go bump instructions #12246

wants to merge 1 commit into from

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels May 19, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 19, 2025
@sbueringer
Copy link
Member Author

/assign @fabriziopandini
Is this what you were looking for?

@sbueringer sbueringer added the area/documentation Issues or PRs related to documentation label May 19, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label May 19, 2025
fabriziopandini
fabriziopandini reviewed May 21, 2025
View reviewed changes
docs/release/role-handbooks/release-lead/README.md Outdated
@@ -168,6 +168,11 @@ The goal of this task is to ensure we are always using the latest Go version for

Note: If the Go minor version of one of our supported branches goes out of supported, we should consider bumping
to a newer Go minor version according to our [backport policy](./../../../../CONTRIBUTING.md#backporting-a-patch).
Usually this is done after k/k bumps the Go version in their release branches. For example:
* Cluster API v1.10 uses Kubernetes v1.32: https://github.com/kubernetes-sigs/cluster-api/blob/v1.10.0/go.mod
* Kubernetes v1.32 uses Go 1.23.8: https://github.com/kubernetes/test-infra/blob/1a5662a/images/kubekins-e2e-v2/variants.yaml#L19
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be

Suggested change
* Kubernetes v1.32 uses Go 1.23.8: https://github.com/kubernetes/test-infra/blob/1a5662a/images/kubekins-e2e-v2/variants.yaml#L19
* Kubernetes v1.32 branch bumps to Go 1.23.8 for any reason (and a coresponding kubekins image is available in https://github.com/kubernetes/test-infra/blob/1a5662a/images/kubekins-e2e-v2/variants.yaml#L19)

Copy link
Member Author

@sbueringer sbueringer May 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used half the suggestion. Adding "branch bumps" seems confusing to me. The list is more a description on how to look up based from a Cluster API version. It's not a sequence of events starting from a Kubernetes Go bump (at least not at the moment)

docs/release/role-handbooks/release-lead/README.md Outdated
@@ -168,6 +168,11 @@ The goal of this task is to ensure we are always using the latest Go version for

Note: If the Go minor version of one of our supported branches goes out of supported, we should consider bumping
to a newer Go minor version according to our [backport policy](./../../../../CONTRIBUTING.md#backporting-a-patch).
Usually this is done after k/k bumps the Go version in their release branches. For example:
* Cluster API v1.10 uses Kubernetes v1.32: https://github.com/kubernetes-sigs/cluster-api/blob/v1.10.0/go.mod
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be

Suggested change
* Cluster API v1.10 uses Kubernetes v1.32: https://github.com/kubernetes-sigs/cluster-api/blob/v1.10.0/go.mod
* Cluster API v1.10 has Kubernetes v1.32 as a dependency, which originally was using Go 1.22: https://github.com/kubernetes-sigs/cluster-api/blob/v1.10.0/go.mod

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the first half the suggestion. Not sure if the latter is helpful. Similar explanation as above.

The whole text here starts with "If the Go minor version of one of our supported branches goes out of support, we should consider bumping"

And this listing here is to explain how to lookup the right Go version we should use (I'll change the text above the listing)

@sbueringer
Improve Go bump instructions
ce7fb12 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@sbueringer sbueringer force-pushed the pr-improve-go-bump branch from 9a41b86 to ce7fb12 Compare May 21, 2025 09:49
@sbueringer
Copy link
Member Author

Pushed a bit of a different version

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from fabriziopandini. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sivchari
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ee110201b46b2e85a84b480420d9c64cbc099266

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@chiukapoor chiukapoor Awaiting requested review from chiukapoor

@hackeramitkumar hackeramitkumar Awaiting requested review from hackeramitkumar

Assignees

@fabriziopandini fabriziopandini

@sivchari sivchari

Labels
area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sbueringer @k8s-ci-robot @sivchari @fabriziopandini