-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[release-1.10] 🐛 Fix pattern on Cluster classNamespace field #12252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.10] 🐛 Fix pattern on Cluster classNamespace field #12252
Conversation
Signed-off-by: Stefan Büringer buringerst@vmware.com
/test pull-cluster-api-e2e-main |
@sbueringer: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @fabriziopandini @JoelSpeed Would be good to merge ASAP so we can include it in the patch release today |
/lgtm I don't think I'm an owner on this branch 🤔 |
LGTM label has been added. Git tree hash: 57de9ca6b6aeb04f5990eb57d484a0e464e74a81
|
Ah yes, good point I forgot In general I would recommed to go through the PRs that have been linked here (#9997) post merge and open a few PRs to ensure you have the right permissions everywhere |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Will do |
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
Validation was wrong because it validated the field for being a subdomain, but it is DNS1123Subdomain instead.
xref: partial cherry-pick from #12235
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #