Skip to content

[release-1.10] 🐛 Fix pattern on Cluster classNamespace field #12252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented May 20, 2025

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:

Validation was wrong because it validated the field for being a subdomain, but it is DNS1123Subdomain instead.

xref: partial cherry-pick from #12235

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone May 20, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 20, 2025
@k8s-ci-robot k8s-ci-robot requested a review from JoelSpeed May 20, 2025 09:16
@k8s-ci-robot k8s-ci-robot added the do-not-merge/needs-area PR is missing an area label label May 20, 2025
@k8s-ci-robot k8s-ci-robot requested a review from vincepri May 20, 2025 09:16
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 20, 2025
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@k8s-ci-robot
Copy link
Contributor

@sbueringer: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-cluster-api-build-release-1-10
/test pull-cluster-api-e2e-blocking-release-1-10
/test pull-cluster-api-e2e-conformance-ci-latest-release-1-10
/test pull-cluster-api-e2e-conformance-release-1-10
/test pull-cluster-api-e2e-mink8s-release-1-10
/test pull-cluster-api-e2e-release-1-10
/test pull-cluster-api-e2e-upgrade-1-32-1-33-release-1-10
/test pull-cluster-api-test-mink8s-release-1-10
/test pull-cluster-api-test-release-1-10
/test pull-cluster-api-verify-release-1-10

The following commands are available to trigger optional jobs:

/test pull-cluster-api-apidiff-release-1-10

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-apidiff-release-1-10
pull-cluster-api-build-release-1-10
pull-cluster-api-e2e-blocking-release-1-10
pull-cluster-api-test-release-1-10
pull-cluster-api-verify-release-1-10

In response to this:

/test pull-cluster-api-e2e-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbueringer
Copy link
Member Author

/assign @fabriziopandini @JoelSpeed

Would be good to merge ASAP so we can include it in the patch release today

@sbueringer sbueringer added the area/clusterclass Issues or PRs related to clusterclass label May 20, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label May 20, 2025
@JoelSpeed
Copy link
Contributor

/lgtm
/approve

I don't think I'm an owner on this branch 🤔

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 20, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 57de9ca6b6aeb04f5990eb57d484a0e464e74a81

@sbueringer
Copy link
Member Author

/lgtm /approve

I don't think I'm an owner on this branch 🤔

Ah yes, good point I forgot

In general I would recommed to go through the PRs that have been linked here (#9997) post merge and open a few PRs to ensure you have the right permissions everywhere

@chrischdi
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2025
@JoelSpeed
Copy link
Contributor

In general I would recommed to go through the PRs that have been linked here (#9997) post merge and open a few PRs to ensure you have the right permissions everywhere

Will do

@k8s-ci-robot k8s-ci-robot merged commit 5255664 into kubernetes-sigs:release-1.10 May 20, 2025
26 checks passed
@sbueringer sbueringer deleted the pr-fix-namespace-pattern branch May 20, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterclass Issues or PRs related to clusterclass cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants