⚠️ Rename deprecated ClusterClass Metadata fields to DeprecatedV1Beta1Metadata #12273
+173
−109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/XXL
|
WIP => needs rebase after #12262 is merged |
sbueringer
changed the title
|
/test pull-cluster-api-e2e-main |
sbueringer
force-pushed
the
pr-rename-metadata-field
branch
from
0530ef8 to
9369bcd
Compare
|
/test pull-cluster-api-e2e-main |
sbueringer
force-pushed
the
pr-rename-metadata-field
branch
from
9369bcd to
cfa3286
Compare
|
/test pull-cluster-api-e2e-main |
sbueringer
force-pushed
the
pr-rename-metadata-field
branch
from
cfa3286 to
0373d90
Compare
|
/test pull-cluster-api-e2e-main |
…tadata Signed-off-by: Stefan Büringer buringerst@vmware.com
sbueringer
force-pushed
the
pr-rename-metadata-field
branch
from
0373d90 to
2f1755a
Compare
k8s-ci-robot
added
size/L
sbueringer
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/test pull-cluster-api-e2e-main |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 4f9fb8da9682ab111a03a14ef0967a6ec1c106c1
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Ideally we would drop the field immediately. Unfortunately we can't because it is part of the VariableDiscovery v1alpha1 API that the metadata surfaces on ClusterClass.
So for now we are just renaming the field on ClusterClass v1beta2. We will drop the field from ClusterClass v1beta2 once we drop v1beta1 support (which is the same time as when we drop support for v1alpha1 VariableDiscovery)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #11947