-
Notifications
You must be signed in to change notification settings - Fork 1.4k
✨ Add Scaleway infrastructure provider to clusterctl #12357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Welcome @Tomy2e! |
Hi @Tomy2e. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
@@ -72,6 +72,7 @@ const ( | |||
IonosCloudProviderName = "ionoscloud-ionoscloud" | |||
VultrProviderName = "vultr-vultr" | |||
OpenNebulaProviderName = "opennebula" | |||
ScalewayProviderName = "scaleway" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to double check with @sbueringer
we are ok on omitting the prefix (the github organization) because in this case prefix and provider name match.
this won't lead to name clash in the future, because if someone from another org wants to create a scaleway provider, in this case the org could not not be omitted
https://cluster-api.sigs.k8s.io/developer/providers/contracts/clusterctl#providers-github-org-prefix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes exactly
/lgtm |
LGTM label has been added. Git tree hash: c83bc2b6d101b0ba28177fd0aacc1bf327522424
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mboersma Can you please take a look at the broken link? https://github.com/kubernetes-sigs/cluster-api/actions/runs/15686602040/job/44330408531?pr=12357 (https://capz.sigs.k8s.io/getting-started.html#prerequisites) And open a separate PR to fix it, thank you! |
See also kubernetes-sigs/image-builder#1771 for image building reference. Go Scaleway! |
Merging here manually as the broken link is independent of this PR |
/cherry-pick release-1.10 |
@sbueringer: #12357 failed to apply on top of branch "release-1.10":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@Tomy2e Feel free to open a PR against v1.10 as well, so it will directly show up in our book |
What this PR does / why we need it: This PR adds the newly created Scaleway infrastructure provider to clusterctl. The documentation was updated accordingly.
/area clusterctl