Skip to content

🌱 Skipping test that is failing because of infra issues #12496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2025

Conversation

adilGhaffarDev
Copy link
Contributor

@adilGhaffarDev adilGhaffarDev commented Jul 15, 2025

What this PR does / why we need it:
Skipping Test:
[Feature:IPv6DualStack] Granular Checks: Services Secondary IP Family [LinuxOnly] should function for service endpoints using hostNetwork

This test is being skipped because it consistently fails on EKS clusters.
It also fails in Kind when running on EKS. However, when running on GKE, the same test passes in both Kind and CAPI.

Since we cannot move CAPI jobs to GKE at this time, we are skipping the test in CAPI e2e for now.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #12449

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Jul 15, 2025
@k8s-ci-robot k8s-ci-robot requested a review from elmiko July 15, 2025 20:00
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 15, 2025
@k8s-ci-robot k8s-ci-robot requested a review from sivchari July 15, 2025 20:00
@adilGhaffarDev
Copy link
Contributor Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@adilGhaffarDev: The following commands are available to trigger required jobs:

/test pull-cluster-api-build-main
/test pull-cluster-api-e2e-blocking-main
/test pull-cluster-api-e2e-conformance-ci-latest-main
/test pull-cluster-api-e2e-conformance-main
/test pull-cluster-api-e2e-latestk8s-main
/test pull-cluster-api-e2e-main
/test pull-cluster-api-e2e-main-gke
/test pull-cluster-api-e2e-mink8s-main
/test pull-cluster-api-e2e-upgrade-1-33-1-34-main
/test pull-cluster-api-test-main
/test pull-cluster-api-test-mink8s-main
/test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

/test pull-cluster-api-apidiff-main

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-apidiff-main
pull-cluster-api-build-main
pull-cluster-api-e2e-blocking-main
pull-cluster-api-test-main
pull-cluster-api-verify-main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@adilGhaffarDev
Copy link
Contributor Author

/test pull-cluster-api-e2e-main-gke

@adilGhaffarDev
Copy link
Contributor Author

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2025
@sbueringer
Copy link
Member

/test capi-kubernetes-kind-network-ipv6

@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-main-gke

@adilGhaffarDev
Copy link
Contributor Author

We also need to clone the kind repo in the test YAML, I will open the PR to do that.

@adilGhaffarDev
Copy link
Contributor Author

We also need to clone the kind repo in the test YAML, I will open the PR to do that.

No, I think this line is not needed in the yaml:
https://github.com/kubernetes/test-infra/blob/399bdabc403fef00afc55f51938be3dba82c4eed/config/jobs/kubernetes-sigs/cluster-api/cluster-api-main-presubmits.yaml#L559

@adilGhaffarDev
Copy link
Contributor Author

@sbueringer , please check: kubernetes/test-infra#35239

@adilGhaffarDev
Copy link
Contributor Author

/test pull-cluster-api-e2e-main-gke

@adilGhaffarDev
Copy link
Contributor Author

/test capi-kubernetes-kind-network-ipv6

@sbueringer
Copy link
Member

Yeah, that is what I expected, now the job is running CAPI tests instead of kind tests

@sbueringer
Copy link
Member

sbueringer commented Jul 29, 2025

@adilGhaffarDev Can you try to set workdir: true for the kind repo?

(xref: https://github.com/kubernetes-sigs/prow/blob/0ee99b9ee1bd56595519879d1e01224e0d74eceb/pkg/apis/prowjobs/v1/types.go#L1156)

Like this

    extra_refs:
    - org: kubernetes-sigs
      repo: kind
      base_ref: main
      path_alias: sigs.k8s.io/kind
      workdir: true

@adilGhaffarDev
Copy link
Contributor Author

kubernetes/test-infra#35240

@adilGhaffarDev Can you try to set workdir: true for the kind repo?

(xref: https://github.com/kubernetes-sigs/prow/blob/0ee99b9ee1bd56595519879d1e01224e0d74eceb/pkg/apis/prowjobs/v1/types.go#L1156)

Like this

    extra_refs:
    - org: kubernetes-sigs
      repo: kind
      base_ref: main
      path_alias: sigs.k8s.io/kind
      workdir: true

I think repo: kubernetes should be the work directory, test we are duplicating is this kubernetes-kind-network-ipv6 and it is running kind test but in k8s repo.

@sbueringer
Copy link
Member

Okay looked up the job. Agree. There should be no need to even clone the kind repo?

@adilGhaffarDev
Copy link
Contributor Author

Okay looked up the job. Agree. There should be no need to even clone the kind repo?

agree, I have updated the PR: kubernetes/test-infra#35240

@adilGhaffarDev
Copy link
Contributor Author

/test capi-kubernetes-kind-network-ipv6

@sbueringer
Copy link
Member

sbueringer commented Jul 30, 2025

Hm, two tests cases are failing. Are we sure we are running the same tests? I'm missing the "[Feature:IPv6DualStack]" prefix

@adilGhaffarDev
Copy link
Contributor Author

/test pull-cluster-api-e2e-main

@adilGhaffarDev adilGhaffarDev changed the title 🌱 Test PR for testing on GKE cluster 🌱 Skipping test that is failing because of infra issues Jul 31, 2025
@adilGhaffarDev
Copy link
Contributor Author

/area/e2e-testing
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2025
@adilGhaffarDev
Copy link
Contributor Author

/area e2e-testing

@k8s-ci-robot k8s-ci-robot added area/e2e-testing Issues or PRs related to e2e testing and removed do-not-merge/needs-area PR is missing an area label labels Aug 1, 2025
@adilGhaffarDev
Copy link
Contributor Author

@sbueringer please check

@sbueringer
Copy link
Member

I diff'ed the test cases executed before and after this change. Looks perfect. Thank you!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 564739ad8c2db308b98877326fe9ed844133c7a0

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2025
@sbueringer
Copy link
Member

sbueringer commented Aug 1, 2025

@adilGhaffarDev Would be nice if you can go ahead and open a PR to cleanup the temporary jobs we created in test-infra

@k8s-ci-robot k8s-ci-robot merged commit a4fb649 into kubernetes-sigs:main Aug 1, 2025
30 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Aug 1, 2025
@adilGhaffarDev
Copy link
Contributor Author

@adilGhaffarDev Would be nice if you can go ahead and open a PR to cleanup the temporary jobs we created in test-infra

I will do that.

@sbueringer
Copy link
Member

We also have to backport. Let's see if it just works

@sbueringer
Copy link
Member

/cherry-pick release-1.10

@sbueringer
Copy link
Member

/cherry-pick release-1.9

@sbueringer
Copy link
Member

/cherry-pick release-1.8

@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #12566

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #12567

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #12568

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing e2e tests due to networking conformance test
4 participants