🐛 Bump cluster-autoscaler to v1.33, adjust RBAC, pin apiVersion to v1beta1 #12502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
|
/test pull-cluster-api-e2e-main-gke |
sbueringer
force-pushed
the
pr-bump-fix-autoscaler
branch
from
e6d3e44 to
5f39453
Compare
Signed-off-by: Stefan Büringer buringerst@vmware.com
sbueringer
force-pushed
the
pr-bump-fix-autoscaler
branch
from
5f39453 to
1636804
Compare
k8s-ci-robot
added
size/M
|
/test pull-cluster-api-e2e-main-gke |
sbueringer
commented
Jul 17, 2025
| @@ -542,21 +542,31 @@ func getAuthenticationTokenForAutoscaler(ctx context.Context, managementClusterP | |||
| } | |||
| Expect(managementClusterProxy.GetClient().Create(ctx, sa)).To(Succeed(), fmt.Sprintf("failed to create %s service account", name)) | |||
|
|
|||
| var resources []string | |||
There was a problem hiding this comment.
Just to avoid empty strings in the Role
mboersma
approved these changes
Jul 17, 2025
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 93745e5109c2592ddf4d8a70dfce81a4aa1ec95c
|
|
/assign @elmiko @fabriziopandini |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
Additional context https://kubernetes.slack.com/archives/C8TSNPY4T/p1752765473253889
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #