Skip to content

Conversation

@chandankumar4
Copy link
Contributor

What this PR does / why we need it:

  • Handle MULTIPLE_AREAS in the generated notes
    • From MULTIPLE_AREAS[KCP/CABPK]: Change envVars fields from []EnvVar to *[]EnvVar (#12539) to KCP/CABPK: Change envVars fields from []EnvVar to *[]EnvVar (#12539)
  • Handle multiple colons
    • From Testing:Framework: Watch logs from init containers (#12208) to Testing/Framework: Watch logs from init containers (#12208)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes: #12280

/area release

@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 6, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 6, 2025
@chandankumar4 chandankumar4 changed the title feat: Update release notes tool to handle multiples_areas and colons 🌱 Update release notes tool to handle multiples_areas and colons Sep 6, 2025
@sbueringer
Copy link
Member

@chandankumar4 Do you have time to address the findings above?

@chandankumar4
Copy link
Contributor Author

@chandankumar4 Do you have time to address the findings above?

Yes, I'll try to finish it soon.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 23, 2025
Signed-off-by: chandankumar4 <chandan.kr404@gmail.com>
@sbueringer
Copy link
Member

Thank you very much!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 06fc8ec03c407f690ab1dc97ea53388080dc64c1

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit f4fce77 into kubernetes-sigs:main Nov 24, 2025
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Nov 24, 2025
@chandankumar4 chandankumar4 deleted the update-release-notes branch November 24, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix the MULTIPLE_AREAS and multiple colon(:) in same line of the generated release notes.

3 participants