Skip to content

Commit 05830b5

Browse files
committed
Defaults to false for 0.19
Signed-off-by: Vince Prignano <vince@prigna.com>
1 parent 1666463 commit 05830b5

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

pkg/cache/cache.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ type Options struct {
231231
// This will be used for all object types, unless it is set in ByObject or
232232
// DefaultNamespaces.
233233
//
234-
// Defaults to true.
234+
// Defaults to false.
235235
DefaultEnableWatchBookmarks *bool
236236

237237
// ByObject restricts the cache's ListWatch to the desired fields per GVK at the specified object.
@@ -291,7 +291,7 @@ type ByObject struct {
291291
// assume bookmarks are returned at any specific interval, nor may they
292292
// assume the server will send any BOOKMARK event during a session.
293293
//
294-
// Defaults to true.
294+
// Defaults to false.
295295
EnableWatchBookmarks *bool
296296
}
297297

@@ -326,7 +326,7 @@ type Config struct {
326326
// assume bookmarks are returned at any specific interval, nor may they
327327
// assume the server will send any BOOKMARK event during a session.
328328
//
329-
// Defaults to true.
329+
// Defaults to false.
330330
EnableWatchBookmarks *bool
331331
}
332332

@@ -430,7 +430,7 @@ func newCache(restConfig *rest.Config, opts Options) newCacheFunc {
430430
Transform: config.Transform,
431431
WatchErrorHandler: opts.DefaultWatchErrorHandler,
432432
UnsafeDisableDeepCopy: ptr.Deref(config.UnsafeDisableDeepCopy, false),
433-
EnableWatchBookmarks: ptr.Deref(config.EnableWatchBookmarks, true),
433+
EnableWatchBookmarks: ptr.Deref(config.EnableWatchBookmarks, false),
434434
NewInformer: opts.newInformer,
435435
}),
436436
readerFailOnMissingInformer: opts.ReaderFailOnMissingInformer,

0 commit comments

Comments
 (0)