Merge pull request #2789 from chrischdi/pr-manager-fix-godoc-add-metrics

k8s-ci-robot · web-flow · commit a92b9612b606 · 2024-04-19T02:25:05.000-07:00
📖 manager: fix godoc about http servers
diff --git a/pkg/manager/internal.go b/pkg/manager/internal.go
@@ -382,7 +382,7 @@ func (cm *controllerManager) Start(ctx context.Context) (err error) {
 		}
 	}
 
-	// First start any HTTP servers, which includes health probes and profiling, if enabled.
+	// First start any HTTP servers, which includes health probes, metrics and profiling if enabled.
 	//
 	// WARNING: HTTPServers includes the health probes, which MUST start before any cache is populated, otherwise
 	// it would block conversion webhooks to be ready for serving which make the cache never get ready.

Original file line number	Diff line number	Diff line change
`@@ -382,7 +382,7 @@ func (cm *controllerManager) Start(ctx context.Context) (err error) {`
`382`	`382`	`}`
`383`	`383`	`}`
`384`	`384`
`385`		`- // First start any HTTP servers, which includes health probes and profiling, if enabled.`
	`385`	`+ // First start any HTTP servers, which includes health probes, metrics and profiling if enabled.`
`386`	`386`	`//`
`387`	`387`	`// WARNING: HTTPServers includes the health probes, which MUST start before any cache is populated, otherwise`
`388`	`388`	`// it would block conversion webhooks to be ready for serving which make the cache never get ready.`