Skip to content

Add the ability for scheduling plugins to add/modify requests during request processing #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add the ability for scheduling plugins to add/modify requests during request processing #792

wants to merge 2 commits into from

Conversation

shmuelk
Copy link

@shmuelk shmuelk commented May 7, 2025 •
edited
Loading

Add the ability for PreSchedule, Filter, Scorer, Picker, and PostSchedule scheduler plugins to add/modify the set of headers that are sent to the chosen inference pod with the request.

This is useful for some implementations of disaggregated Prefill/Decode processing require the use of additional headers in the request that is sent to the inference server.

The unit tests added are very simplistic. A better unit test will be added later at the StreamingServer level.

fix: #791

shmuelk added 2 commits May 6, 2025 19:04
@shmuelk
Added support for plugins to add/modify headers
70f6578 
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
@shmuelk
Added mutating header tests
c0f5905 
Signed-off-by: Shmuel Kallner <kallner@il.ibm.com>
@netlify Netlify
Copy link

netlify bot commented May 7, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit c0f5905
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/681b507d86bbc40008942009
😎 Deploy Preview https://deploy-preview-792--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 7, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and danehans May 7, 2025 12:22
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shmuelk
Once this PR has been reviewed and has the lgtm label, please assign ahg-g for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @shmuelk. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 7, 2025
@nirrozenbaum
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 7, 2025
@shmuelk
Copy link
Author

shmuelk commented May 7, 2025

On the previous version of this PR (#760) @liu-cong commented the following:

The headers is a list. If the plugins updated the value of an existing header key, should we update the header here instead of just appending?

The Envoy gRPC API used to add and/or modify headers, has in it the list of headers to be added or modified. This list is not the list of all of the headers that will sent with the request. The code is simply building that list.

@shmuelk
Copy link
Author

shmuelk commented May 7, 2025

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@shmuelk shmuelk closed this May 8, 2025
@shmuelk shmuelk deleted the mutated-headers branch May 8, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g Awaiting requested review from ahg-g

@danehans danehans Awaiting requested review from danehans

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the ability for scheduling plugins to add/modify requests during request processing
3 participants
@shmuelk @k8s-ci-robot @nirrozenbaum