Skip to content

Incorrect conformance tests and reporting for Mesh? #3581

@LiorLieberman

Description

@LiorLieberman

What happened:
Looking into our conformance reports and tests for Mesh, I see features being reported as "supported" but suspect we are not even testing them. Taking istio as an example.

  1. The last conformance report reports support for many features.
  2. If we take HTTPRoutePathRewrite as an example, we can see that the test for this feature only deploys an HTTPRoute with a Gateway as a parentRef and not a Service.
  3. In fact, most of the tests for HTTPRoute features are not covering mesh functionalities. There are only a few tests that actually tests mesh and those are the feature names that start with "Mesh"
  4. This leads to incorrect reporting - implementations that support N/W HTTPRoute functionalities reports the same support for mesh if they pick the mesh profile.
  5. While this case should be ideal, its not 100% the case, and we basically have minimal coverage for Mesh support.

What you expected to happen:
We should test every feature thats applicable to mesh (should be most of the features if we stick to the vision) with Service as a parentRef in addition to Gateway.

Ideally we should address this as a framework change with support to exclude features as opposed to add this functionality to every test. The Service-as-a-parentRef tests should only be running if the implementation indicated that they support the MESH profile.

/area conformance
/cc @howardjohn @robscott @youngnick @mlavacca @kflynn @shaneutt @mikemorris

Metadata

Metadata

Assignees

Labels

area/conformance-machineryIssues or PRs related to the machinery and the suite used to run conformance tests.area/meshMesh networks relatedkind/bugCategorizes issue or PR as related to a bug.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.release-blockerMUST be completed to complete the milestonev1.4-release/subtaskThis indicates a subtask of a feature, bug, or smaller issue for the v1.4 release.

Type

Projects

Status

Completed

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions